Skip to content

[Repo Assist] perf: skip StringBuilder in single-frame WebSocket receive; fix double payload.ToString() #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shanselman merged 1 commit into from
Apr 1, 2026
Merged

[Repo Assist] perf: skip StringBuilder in single-frame WebSocket receive; fix double payload.ToString() #119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions src/OpenClaw.Shared/WebSocketClientBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,11 +137,20 @@ private async Task ListenForMessagesAsync()

if (result.MessageType == WebSocketMessageType.Text)
{
sb.Append(Encoding.UTF8.GetString(buffer, 0, result.Count));
if (result.EndOfMessage)
if (result.EndOfMessage && sb.Length == 0)
{
await ProcessMessageAsync(sb.ToString());
sb.Clear();
// Fast path: single-frame message — decode directly, skip StringBuilder round-trip
await ProcessMessageAsync(Encoding.UTF8.GetString(buffer, 0, result.Count));
}
else
{
// Multi-frame path: accumulate until EndOfMessage
sb.Append(Encoding.UTF8.GetString(buffer, 0, result.Count));
if (result.EndOfMessage)
{
await ProcessMessageAsync(sb.ToString());
sb.Clear();
}
}
}
else if (result.MessageType == WebSocketMessageType.Close)
Expand Down
3 changes: 2 additions & 1 deletion src/OpenClaw.Shared/WindowsNodeClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,7 +437,8 @@ private void HandleResponse(JsonElement root)
return;
}

_logger.Debug($"[NODE] Response payload: {payload.ToString().Substring(0, Math.Min(200, payload.ToString().Length))}...");
var payloadText = payload.ToString();
_logger.Debug($"[NODE] Response payload: {payloadText.Substring(0, Math.Min(200, payloadText.Length))}...");

// Handle hello-ok (successful registration)
if (payload.TryGetProperty("type", out var t) && t.GetString() == "hello-ok")
Expand Down