fix(runner): close static scanner path bypasses - #41
Merged
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.git,node_modules,vendor, or.venvare scanned while real directories remain excluded__pycache__and emit explicit high-severity evidence for packaged Python bytecode instead of silently hiding it as a skipped directory.gitpayload from [Bug]: clawscan-static skips .git files (not just directories) (malicious skill example that bypasses this scanner) #40 produces a findingThe built-in judge workspace already copied
__pycache__; the transitive blind spot was in scanner evidence and directtarget.filesrendering. This keeps the separate workspace.gitexclusion intact so worktree pointers are not copied.Proof
.gitfixture reportedskipped pathand zero findings..pycfixture reported its__pycache__directory asskipped pathand zero findings.static.python_process_executionon.gitandstatic.python_bytecodeon the full.pycpath..gitpointer remain finding-free; a realnode_modulesdirectory remains excluded.Commands run:
All passed. The first default-TMPDIR suite run exposed an existing macOS
/varversus/private/varalias assertion; rerunning with the canonical/private/tmppath passed every package.Thanks @nedlir for the concrete bypass fixtures, and @Patrick-Erichsen for maintaining this scanner surface.
Fixes #39
Fixes #40