Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attribute linting and ecosystem support. #19

Closed

Commits on Jul 1, 2019

  1. Add attribute linting and ecosystem support.

    I keep repeating the same Elixir code in my reporters, middleware, and unit
    tests. This commit extracts all that code, cleans it up, and makes it
    available for everyone else working with Opencensus in Elixir.
    
    - **Alter `Opencensus.Trace.with_child_span/2` attribute handling**
    - Add `Opencensus.Trace.put_span_attributes/1`
    - Add `Opencensus.Trace.async/1`
    - Add `Opencensus.Trace.async/3`
    - Add `Opencensus.Trace.await/1`
    - Add `Opencensus.Span` struct derived from the record
    - Add `Opencensus.Span.from/1`
    - Add `Opencensus.Span.load/1`
    - Add `Opencensus.SpanContext` struct derived from the record
    - Add `Opencensus.SpanContext.from/1`
    - Add `Opencensus.SpanContext.hex_trace_id/1`
    - Add `Opencensus.SpanContext.hex_span_id/1`
    - Add `Opencensus.TestSupport.SpanCaptureReporter`
    - Add `Opencensus.Attributes.process_attributes/1`
    - Add `Opencensus.Attributes.process_attributes/2`
    - Add `Opencensus.Attributes.default_attributes/1`
    
    The new attribute handling:
    
    - **Drops span attributes with unsupported values**
    
    - **Flattens nested maps**
    
    - Documents the value support limits imposed by the Opencensus wire protocol
      and `:ocp.put_span_attribute/2`
    
    - Preserves the `:module`, `:file`, `:function`, `:line`, and `:default`
      magic attributes
    
    Misc:
    
    - `mix credo`
    - `mix test.watch`
    Garth Kidd committed Jul 1, 2019
    Configuration menu
    Copy the full SHA
    8f569e9 View commit details
    Browse the repository at this point in the history
  2. Upgrade 'mix format' in CI to 1.8.1.

    Garth Kidd committed Jul 1, 2019
    Configuration menu
    Copy the full SHA
    92eca39 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2019

  1. Take feedback on attribute documentation.

    Garth Kidd committed Jul 3, 2019
    Configuration menu
    Copy the full SHA
    ee635be View commit details
    Browse the repository at this point in the history
  2. Fix documentation strings.

    Garth Kidd committed Jul 3, 2019
    Configuration menu
    Copy the full SHA
    5965462 View commit details
    Browse the repository at this point in the history