Logger metadata and documentation #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #15 +/- ##
==========================================
+ Coverage 94.44% 95.45% +1.01%
==========================================
Files 1 2 +1
Lines 18 22 +4
==========================================
+ Hits 17 21 +4
Misses 1 1
Continue to review full report at Codecov.
|
hauleth
reviewed
May 18, 2019
zachdaniel
approved these changes
May 19, 2019
There was a problem hiding this comment.
While I generally agree with the idea that we shouldn’t be so specific about the underlying implementation, this is a really positive change overall. it’s possible that, in the early stages at least, documenting too much is better than not having enough. So either way seems good to me.
added 6 commits
June 17, 2019 14:35
garthk
force-pushed
the
logger-metadata-and-documentation
branch
from
37a9a79 to
33f2e3c
Compare
|
I've rebased, and committed revisions per feedback separately so they're easier to find. |
tsloughter
reviewed
Jun 25, 2019
tsloughter
approved these changes
Jun 25, 2019
This was referenced Jun 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bit of an omnibus. Started with the badges, and rolled from there. Please let me know if any of this is misconceived or out of line.