Small fixes [for case of packet fragmentation] #102
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 93.53% (diff: 100%)@@ 1.4.0 #102 diff @@
==========================================
Files 4 4
Lines 2180 2181 +1
Methods 126 126
Messages 0 0
Branches 475 475
==========================================
+ Hits 2039 2040 +1
Misses 141 141
Partials 0 0
|
There was a problem hiding this comment.
So these are the tests for #101 ? If yes, why not combine both PRs? Curious on this one and also confused on the order I'm supposed to merge.
| @@ -1597,6 +1597,8 @@ function OpenBCIFactory () { | |||
| this.curParsingMode = k.OBCIParsingNormal; | |||
| this.buffer = null; | |||
| this.emit('ready'); | |||
| } else { | |||
|
I'm surprised this passed tests because fragmentation is not in master |
|
will rebase onto #100 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These adjustments allow the tests to pass if #101 is merged or used.
Incidentally also fixes some initialization issues when communicating with a real live board.