Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2019 postcode mapping #71

Merged
merged 1 commit into from
May 28, 2019
Merged

Conversation

jamezpolley
Copy link
Member

Updated list of electorates/postcodes for the 2019 federal election.

@ghost ghost assigned jamezpolley May 14, 2019
@ghost ghost added the in progress label May 14, 2019
@jamezpolley
Copy link
Member Author

I'm not sure if this can be committed yet; as it would leave us with some sitting members in seats that aren't in this list and some seats without members.

On the other hand, not committing it means that we'll still be serving up people's current division, when what they're probably after is what division they're going to be voting in in the upcoming election.
so..

I'm not sure what to do.,

@jamezpolley jamezpolley force-pushed the 2019-postcode-mapping branch 3 times, most recently from cfaca70 to 4b1a17d Compare May 14, 2019 10:06
@jamezpolley jamezpolley changed the base branch from master to sort-by-postcode May 14, 2019 10:07
@mackaymackay
Copy link
Contributor

@jamezpolley my immediate feeling is to make the change.. Most people using the site this week will be using it for election-related reasons, so it's best that the postcode mapping is correct, even if it causes some confusion due to those matters you mentioned. Better than spreading misinformation, yeah? And they can always email us if they're having trouble.. That said, it's also not the end of the world if you'd prefer to hold off until next week.

@jamezpolley
Copy link
Member Author

For reference, the data in this list was pulled via the scraper at https://morph.io/openaustralia/aec_postcode_electorate_data

@jamezpolley jamezpolley merged commit 147474b into sort-by-postcode May 28, 2019
@jamezpolley jamezpolley deleted the 2019-postcode-mapping branch May 28, 2019 05:00
@jamezpolley
Copy link
Member Author

jamezpolley commented May 29, 2019

I'm having trouble building a test environment to test this in.

Our version of mysql is too old and doesn't seem to be available any more

The Ansible module we use for installing RVM installs the latest version of bundler. That's 2.0.1, which doesn't work on old versions of Ruby like the one we're using.

We can work around that by manually installing an older version of bundler, but then we run into other issues with the recent versions of RVM. It looks like the issue we're hitting here is that RVM is trying to install no-longer-available versions of various packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants