Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add devices-l command for device paths #136

Merged
merged 3 commits into from
Aug 29, 2024
Merged

Conversation

gyatskov
Copy link
Contributor

@gyatskov gyatskov commented Jun 24, 2024

While props can be individually queried via getprop it would be convenient to see them and transport_id at once, per device (one request only):

➜  adbutils git:(master) python -m adbutils --list
xxxxxxxxxxxxxxxxxx  SM-G950F
➜  adbutils git:(master) python -m adbutils --list-extended
xxxxxxxxxxxxxxxxxx  device_version:1-1.4 product:dreamltexx model:SM_G950F device:dreamlte transport_id:9

Copy link

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 10.71429% with 25 lines in your changes missing coverage. Please review.

Project coverage is 30.96%. Comparing base (e194766) to head (68d6c4f).

Files Patch % Lines
adbutils/__init__.py 7.14% 13 Missing ⚠️
adbutils/__main__.py 0.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #136      +/-   ##
==========================================
- Coverage   31.23%   30.96%   -0.28%     
==========================================
  Files          15       15              
  Lines        1988     2009      +21     
  Branches      323      334      +11     
==========================================
+ Hits          621      622       +1     
- Misses       1343     1363      +20     
  Partials       24       24              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

 * Extend stubbed adb server for testing host:devices and host:devices-l
commands.

 * Simplify AdbClient.list: Generic handling of description tags
@gyatskov
Copy link
Contributor Author

gyatskov commented Jul 30, 2024

Unit tests added (codecov reevaluation will only trigger after maintainer approval).

@codeskyblue codeskyblue merged commit 1be9212 into openatx:master Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants