Include <sys/time.h> #278
Open
Include <sys/time.h> #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to POSIX `struct timeval` is defined if <sys/time.h> is included. This fixes the build with musl, which is rather strict when it comes to standards.
|
Just out of curiosity: Which distribution do you use for testing? And how far did you get building openambit with musl? |
|
Some more required changes are on branch https://github.com/openambitproject/openambit/tree/support_musl but building on Alpine Linux did then fail during linking... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to POSIX
struct timevalis defined if <sys/time.h> isincluded.
This fixes the build with musl, which is rather strict when it comes
to standards.