Add menu option for save watch configs #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additional installation instructions for ubuntu.
Update build infra structure
Merge to local master
- This write the current settings and apps to JSON files as part of regular syncing in CLI or GUI. - Files are saved in the same place as openambit.conf
- The entry is "Save configuration for the watch (JSON file)" - When this option is activated, watch aps and settings will be stored on openambit config folder as JSON files (apprules and settings"
centic9
reviewed
Oct 21, 2020
build.sh
Outdated
| if [ "$DO_INSTALL" == "1" ]; then | ||
| echo "------installing $target------" | ||
| sudo make install | ||
| sudo ldconfig |
There was a problem hiding this comment.
There are some unrelated newline/blank changes, maybe you can revert them?
There was a problem hiding this comment.
ok, I will revert them
src/movescount/movescount.cpp
Outdated
| QJsonDocument doc = QJsonDocument::fromJson(_data); | ||
| QString formattedJsonString = doc.toJson(QJsonDocument::Indented); | ||
|
|
||
| //formattedJsonString.replace("", ""); |
There was a problem hiding this comment.
maybe you can remove this commented code here
src/openambit-cli/.gitignore
Outdated
| @@ -0,0 +1 @@ | |||
| personal_config.h | |||
There was a problem hiding this comment.
is this gitignore useful in general or just a leftover?
There was a problem hiding this comment.
Just a leftover. I used to store a different APPKEY there, because on Task.cpp I had:
+#include "personal_config.h"
+++ b/src/openambit-cli/Task.cpp
@@ -7,8 +7,11 @@
#include <movescount/logstore.h>
#include <movescount/movescountxml.h>
#include <libambit_int.h>
+#include "personal_config.h"
-#define APPKEY "HpF9f1qV5qrDJ1hY1QK1diThyPsX10Mh4JvCw9xVQSglJNLdcwr3540zFyLzIC3e"
+#ifndef APPKEY
+ #define APPKEY "HpF9f1qV5qrDJ1hY1QK1diThyPsX10Mh4JvCw9xVQSglJNLdcwr3540zFyLzIC3e"
+#endif
#define MOVESCOUNT_DEFAULT_URL "https://uiservices.movescount.com/"
- Revert unrelated newline/blank changes. - Remove commented code. - Remove .gitingnoe on src/openambit-cli/.gitignore
centic9
approved these changes
Oct 24, 2020
|
The command-line application now also learned this, see commit 6c3c781 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a menu entry in openambit app, to save watch config and apps, on a JSON file. This PR is related to #256
Add sync menu option for synchronizing watch apps
As this is a large patch, I explain what the functions do. Any advice will be well accepted :D
As a comment, I noticed that my APPKEY is different. To connect with movescount, you need to change this.