Remove test-skip comment for macOS arm64#562
Open
AvinZarlez wants to merge 1 commit into
Open
Conversation
No longer skipping tests for arm64 builds, since GitHub action runners for macos latest are Arm64 based.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor configuration change to remove the
test-skipsetting that previously skipped tests forarm64macOS wheels.It seems there was an assumption that the MacOS image on GitHub Action runners was Intel based, but in fact the latest versions have been running Arm based MacOS runners for a while.
Testing this out seem to run fine on arm, no warnings. This has been cross compiling for x86 while running on Arm based hardware without a problem.