Repository navigation
feat(api): add prewarmed hosted environments - #818
Conversation
Castiron-Internal-PR: openai/openai-ruby-internal#204 Castiron-Source-SHA: cb685d7c1f5b605ff00561234fbb4bcc2a99aee1 Castiron-Public-Base-SHA: 500f9fc
Castiron custom codeEvaluated main: ✅ No new custom-code files detected. 84 mixed files remain; 0 existing customizations changed; 8 generated baselines changed. Compared
76 existing customizations unchanged
36 more in the full report. A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 37881494277 --repo openai/openai-ruby \
--name castiron-custom-code-37881494277-1 --dir /tmp/castiron-custom-code-37881494277-1
git apply --stat /tmp/castiron-custom-code-37881494277-1/custom-code.patch
cat /tmp/castiron-custom-code-37881494277-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 500f9fc6ad1e3a77f9a0bf4f7918039464873765 21167bf31d1b650f863011f52128d783e4e3d653
python3 scripts/castiron/custom_code_report.py report \
--base 500f9fc6ad1e3a77f9a0bf4f7918039464873765 \
--head 21167bf31d1b650f863011f52128d783e4e3d653 --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-21167bf31d1b
cat /tmp/castiron-custom-code-21167bf31d1b/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
markstuart-oai
left a comment
markstuart-oai
left a comment
There was a problem hiding this comment.
Reviewed 21167bf31d1b650f863011f52128d783e4e3d653. No blocking correctness or maintainability findings.
The resource methods now pass default headers through the existing transport merge. Unrelated caller headers preserve OpenAI-Beta, while explicit overrides remain case-insensitive. Streaming headers and the named environment idempotency_key parameter remain intact.
The prewarm models match the schema and preserve empty hosted configuration and explicit desktop.enabled: false. They reuse the existing pagination and webhook parsing paths. Session attachment by environment ID keeps the existing inline and template options. The change adds no generic transport branch or new pagination layer.
Validation: hosted Ruby 3.3, 3.4, 4.0 and Bedrock tests, RuboCop, RBI/RBS checks, package, required CI, CodeQL and Castiron checks passed for this head. This was a source review, including existing tests. I did not run repository workloads or call the beta API. Prewarming still requires beta access and OpenAI-Beta: agents=v1.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
2 participants
Prepare an OpenAI-hosted environment before creating a beta Agents session. Add environment creation and paginated listing, session attachment by environment ID, the standalone ready status, and ready/failed webhook parsing. Prewarming access and
OpenAI-Beta: agents=v1remain required.Method-specific default headers survive unrelated caller headers. Explicit overrides remain case-insensitive, and creation preserves caller idempotency keys.