Skip to content

Commit

Permalink
Prepare 2.0.0-beta.12 release (Part 3) (#221)
Browse files Browse the repository at this point in the history
Improvements to test reliability
  • Loading branch information
joseharriaga committed Sep 20, 2024
1 parent d9bc167 commit bbac88f
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 4 deletions.
1 change: 0 additions & 1 deletion tests/Assistants/Assistants.VectorStoresTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ namespace OpenAI.Tests.VectorStores;

[TestFixture(true)]
[TestFixture(false)]
[Parallelizable(ParallelScope.Fixtures)]
[Category("Assistants")]
public class VectorStoresTests : SyncAsyncTestBase
{
Expand Down
1 change: 0 additions & 1 deletion tests/Assistants/AssistantsSmokeTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ namespace OpenAI.Tests.Assistants;

#pragma warning disable OPENAI001

[Parallelizable(ParallelScope.Fixtures)]
[Category("Assistants")]
[Category("Smoke")]
public class AssistantsSmokeTests
Expand Down
1 change: 0 additions & 1 deletion tests/Assistants/AssistantsTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ namespace OpenAI.Tests.Assistants;

[TestFixture(true)]
[TestFixture(false)]
[Parallelizable(ParallelScope.Fixtures)]
[Category("Assistants")]
public class AssistantsTests : SyncAsyncTestBase
{
Expand Down
4 changes: 3 additions & 1 deletion tests/Models/ModelsTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,9 @@ public void DeleteModelCanParseServiceError()
ex = Assert.Throws<ClientResultException>(() => client.DeleteModel("fake_id"));
}

Assert.That(ex.Status, Is.EqualTo(403));
// If the model exists but the user doesn't own it, the service returns 403.
// If the model doesn't exist at all, the service returns 404.
Assert.That(ex.Status, Is.EqualTo(404));
}

[Test]
Expand Down

0 comments on commit bbac88f

Please sign in to comment.