fix: #3363 honor short custom voice splitter chunks#3364
Open
Aphroq wants to merge 1 commit into
Open
Conversation
Aphroq
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Honor non-empty chunks returned by custom voice
text_splitterfunctions, even when they are shorter than 20 characters.This lets custom splitters decide when text is ready for TTS and keeps turn lifecycle events balanced when the splitter consumes all buffered text before
_turn_done().Test plan
uv run pytest tests/voice/test_pipeline.py -qbash .agents/skills/code-change-verification/scripts/run.shThe focused voice pipeline tests pass on this branch directly. The full shell verification script was run in a local validation checkout where this branch was temporarily combined with the pending tracing shutdown fix, so the tracing atexit cleanup test would not time out.
Issue number
Closes #3363
Checks
make lintandmake format