feat: add approval override argument parity for RunState resumes#2695
Open
feat: add approval override argument parity for RunState resumes#2695
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1e8b70a05e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds TypeScript-parity approval argument overrides to the Python SDK's HITL resume flow (see openai/openai-agents-js#1098 for TS implementation). It extends
RunState.approve()with durable and execution-only override modes, persists the new override bookkeeping in schema1.7, and updates replay surfaces so resumed tool execution, serialized state, and local canonical history stay aligned.It also introduces Python equivalents of rewrite-aware and server-managed session capabilities.
SQLiteSessionandOpenAIResponsesCompactionSessioncan now rewrite persisted function-call history,OpenAIConversationsSessionadvertises server-managed history semantics for validation, and the runner now fails fast when a requested override mode is incompatible with the active session or conversation setup.Finally, this pull request keeps compaction and tracing behavior consistent with the corrected transcript. Session persistence applies pending history mutations even on approval-only save cycles, compaction stays in input mode after local rewrites until a newer response id is observed, and approval overrides emit an audit custom span only when sensitive tracing is enabled. Regression coverage was added across sync resumes, streamed resumes, tracing, and compaction.