Skip to content

Fix log injection error #1544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix log injection error #1544

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions evals/elsuite/multistep_web_tasks/docker/flask-playwright/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,18 +180,20 @@ def _execute_command(json_data: dict):
if command is None:
raise ValueError("No command", jsonify({"status": "error", "message": "no command"}))

# Sanitize the command to prevent log injection
sanitized_command = command.replace('\r\n', '').replace('\n', '')

try:
result = eval(command)
return result
except Exception as e:
logger.info(f"Error executing command: {command}")
logger.info(f"Error executing command: {sanitized_command}")
logger.error(e)
raise ValueError(
f"Error executing command {command}",
jsonify({"status": "error", "message": f"error executing command {command}: {e}"}),
f"Error executing command {sanitized_command}",
jsonify({"status": "error", "message": f"error executing command {sanitized_command}: {e}"})
)


def _execute_commands(json_data: dict):
results = {}
for command in json_data["commands"]:
Expand Down