Skip to content

Send installation id in Responses headers#25182

Draft
jiamingz42 wants to merge 1 commit into
mainfrom
dev/jm/codex-installation-id-response-headers
Draft

Send installation id in Responses headers#25182
jiamingz42 wants to merge 1 commit into
mainfrom
dev/jm/codex-installation-id-response-headers

Conversation

@jiamingz42
Copy link
Copy Markdown
Contributor

Summary

  • Move x-codex-installation-id into the shared Responses identity headers so regular /responses HTTP and Responses websocket handshakes carry the same installation id header as /responses/compact.
  • Keep existing client_metadata propagation intact.
  • Skip the header when the installation id is empty or invalid, so clients do not send empty installation id headers.

Testing

  • cargo test -p codex-core installation_id -- --nocapture
  • cargo test -p codex-core --test responses_headers responses_stream_includes_subagent_header_on_review -- --nocapture
  • cargo test -p codex-core --test all responses_websocket_streams_request -- --nocapture
  • cargo test -p codex-core --test all remote_compact_replaces_history_for_followups -- --nocapture
  • cargo fmt -- --config imports_granularity=Item --check
  • cargo clippy -p codex-core --lib --no-deps -- -D warnings

Not run to completion:

  • cargo clippy -p codex-core --tests -- -D warnings stopped on an existing unrelated clippy::while_let_loop warning in code-mode/src/runtime/mod.rs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant