Send installation id in Responses headers#25182
Draft
jiamingz42 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
x-codex-installation-idinto the shared Responses identity headers so regular/responsesHTTP and Responses websocket handshakes carry the same installation id header as/responses/compact.client_metadatapropagation intact.Testing
cargo test -p codex-core installation_id -- --nocapturecargo test -p codex-core --test responses_headers responses_stream_includes_subagent_header_on_review -- --nocapturecargo test -p codex-core --test all responses_websocket_streams_request -- --nocapturecargo test -p codex-core --test all remote_compact_replaces_history_for_followups -- --nocapturecargo fmt -- --config imports_granularity=Item --checkcargo clippy -p codex-core --lib --no-deps -- -D warningsNot run to completion:
cargo clippy -p codex-core --tests -- -D warningsstopped on an existing unrelatedclippy::while_let_loopwarning incode-mode/src/runtime/mod.rs.