Route standalone image generation through host finalization md#25176
Open
won-openai wants to merge 1 commit into
Open
Route standalone image generation through host finalization md#25176won-openai wants to merge 1 commit into
won-openai wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Standalone image-generation extensions emitted turn items through the low-level event path, bypassing host-owned finalization such as image persistence and contributor processing. At the same time, the generated-image save-path hint must remain visible to the model through the extension tool's
FunctionCallOutput, rather than the legacy built-in developer-message path.What changed
ExtensionTurnItemto support image-generation items while keeping the extension-facing emitter API limited toemit_startedandemit_completed.finalize_turn_item, so standalone image-generation items receive host-owned processing and persistedsaved_pathvalues before publication.FunctionCallOutput.Validation
just fmtjust test -p codex-image-generation-extensionjust test -p codex-web-search-extensionjust test -p codex-goal-extensionjust test -p codex-memories-extensioncodex-coretests for image save history, extension completion finalization, and contributor executionjust test -p codex-app-server standalone_image_generation_returns_saved_path_hint_to_modeljust fix -p codex-corejust fix -p codex-image-generation-extensionjust bazel-lock-updatejust bazel-lock-check