[app-server][core] Add connector-level Guardian reviewer overrides#25167
Open
zamoshchin-openai wants to merge 1 commit into
Open
[app-server][core] Add connector-level Guardian reviewer overrides#25167zamoshchin-openai wants to merge 1 commit into
zamoshchin-openai wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[from codex]
Summary
apps.<connector_id>.approvals_reviewerto override Guardian or user review routing per connected appValidation
just fmtjust write-config-schemajust write-app-server-schemajust write-app-server-schema --experimental(validated, then regenerated standard checked-in fixtures)just test -p codex-config -p codex-core -p codex-app-server-protocol -p codex-app-server -E "test(app_approvals_reviewer) | test(routes_approval_to_guardian_can_use_app_reviewer_override) | test(codex_apps_mcp_uses_connector_approvals_reviewer_override) | test(delegated_mcp_guardian_abort_returns_synthetic_decline_answer) | test(config_read_includes_apps) | test(schema_fixtures) | test(write_value_supports_nested_app_paths)"(12 passed; recipe benchmark smoke passed)just fix -p codex-config -p codex-core -p codex-app-server-protocol -p codex-app-serverAdditional validation note
just test -p codex-config -p codex-core -p codex-app-server-protocol -p codex-app-server; it compiled the changed code but did not pass in this checkout because unrelated core integration tests could not locatetarget/debug/test_stdio_serverand several shell/unified-exec timing tests timed out under the run.