[codex] Support more Vim normal commands#25158
Draft
jinghanx88 wants to merge 1 commit into
Draft
Conversation
753a90f to
ce5e592
Compare
32f66d6 to
2f6b50d
Compare
2f6b50d to
159f9c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gg/G,dG,yG,dgg, andcG/cgg.c{motion}for normal motions such ascw,c$, andcc, entering insert mode after deleting the target range.vand linewise visual mode withV, includingy,d/x, andc/sactions on the selected range.., multi-level undo withu, and redo withCtrl-R./keymap, and render visual/visual-line indicators without panicking.Test plan
just write-config-schemajust test -p codex-configjust test -p codex-tui ...coverage for Vim change motions, visual line mode, repeat, undo/redo, andgg/Goperator targets.just test -p codex-tui keymap_setup::testsafter accepting expected keymap action-count snapshots.cargo insta pending-snapshots --manifest-path tui/Cargo.tomlreports no pending snapshots.just test -p codex-tuipasses 2772 tests and still fails only the existing Guardian tests:app::tests::update_feature_flags_disabling_guardian_clears_manual_review_policy_without_history,app::tests::update_feature_flags_disabling_guardian_clears_review_policy_and_restores_default.just fix -p codex-tuigit diff --check