feat(mcp): load pending tools through lazy search [5 of 5]#24987
feat(mcp): load pending tools through lazy search [5 of 5]#24987fcoury-oai wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b361c419ba
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
6e4e0d4 to
dfc410a
Compare
e93cabb to
1a636e4
Compare
1a636e4 to
2a1c9cd
Compare
ec71f9c to
551f4b4
Compare
2a1c9cd to
b195974
Compare
Why
Search-capable turns should not wait for uncached optional MCP servers during initial tool construction. When the model actually needs a deferred MCP capability,
tool_searchcan load the pending inventory on demand without keeping MCP initialization on the ordinary critical path.What Changed
tool_searchfor search-capable namespaced providers.MCP Error Reporting
With the default
[tui] show_mcp_startup_status = false, unused background startup failures remain quiet. Explicit app, plugin, and skill dependencies still emitMCP dependency \` requested for this turn is unavailable: `. A search-only server that fails startup contributes no lazy search results; this PR does not add a new warning for that path.Stack
How to Test
Targeted tests run:
just test -p codex-core -E 'test(tool_search_returns_deferred_tools_without_follow_up_tool_injection) | test(non_search_model_waits_for_pending_apps_tools_on_first_request) | test(codex_apps_file_params_upload_local_paths_before_mcp_tool_call) | test(pending_apps_inventory_omits_connector_install_suggestions_but_keeps_plugins)'just test -p codex-tui -E 'test(startup_header_commit_defers_draw_until_session_info_is_committed) | test(quiet_session_configuration_does_not_defer_draw_for_header_commit)'