fix(cost): enforce verifiable scan spending limits by mldangelo-oai · Pull Request #465 · openai/codex-security

mldangelo-oai · 2026-08-15T19:49:24Z

Summary

Enforce an explicitly requested scan spending limit when completed root or worker usage cannot be verified. Scans without a limit keep best-effort cost reporting.

Changes

Accumulate owned usage across counter resets without charging inherited fork history or counting custom-validation receipts twice.
Check all owned rollout paths through the existing read-only session graph during budgeted finalization. Keep unrelated sessions and optional accounting separate.
Preserve completed usage, observed overages and cancellation while worker streams drain.
Integrate current main and refresh the paired plugin version at 0.1.99. Restore worker stream draining in canonical MCP source so completed usage can flush before the worker settles.
Reuse main's credential filtering and UTF-8 Python helpers, while preserving the ownership-accounting and artifact-restoration regressions.

Testing

Merge conflict resolution at 47a286232cc4e1f01cbee19ea9cb015f0e701584 against main at 6750642c94edce8d60112f816631de05dc10efd6:

Combine verifiable final cost accounting with main's live budget increases and completed validation receipts. Keep worker completion required when a spending limit is explicitly requested.
Focused cost tests: 199 passed.
Focused API budget/cost and custom-validation checks: 59 passed initially; the live-budget fixture was updated to record completed worker usage and passed on rerun.
SDK TypeScript check, plugin bundle generation, changed-file formatting, all three portable plugin source checks, and git diff --check passed.
The full test suite was left to CI.

Earlier validation recorded for prior heads:

Current base integration on aa383f54446a1914d1bb2d691f4512c937298416:

Cost, API, custom-validation, worker-shutdown and runtime suites: 520 passed, with 23 platform skips.
The existing worker-drain regressions failed before the authored runtime change was restored to canonical source and passed afterward. A real-process fixture also confirmed that early shutdown loses the final usage write.
Artifact-server checks passed on retry; complete Node MCP verification was interrupted by disk exhaustion. The updated worker fixture checks usage flushing and cancellation without leaving a permanently hanging child.
Types, generated models, MCP typechecking, formatting, plugin build, Ruff lint/format and portable source checks passed.

Complete local full-suite and installed-package verification is blocked by repeated disk exhaustion. Interrupted runs are not treated as passing. Fresh CI is requested for the new head; its outcome is separate from human approval.

Risk and rollout

No new CLI options or accounting policy. An explicit limit now rejects unverifiable completed usage; optional reporting remains tolerant. Counter-reset histories may reconstruct higher estimates, while inherited fork history is excluded from child usage. Existing stored costs and pricing tables are unchanged. The synchronized bundle version refreshes cached installations. This PR remains a draft.

Public disclosure review

No customer, partner, prospect, or user identities, data, or identifying details are included.
No credentials, personal data, private source, scan findings, or nonpublic links or tickets are included.
I reviewed the branch name, title, description, commits, changes, comments, logs, screenshots, attachments, and links for public disclosure.

Existing commit contact metadata and account-specific automated review links prevent the second attestation. This update uses synthetic fixtures and a GitHub noreply commit identity; historical metadata and other authors' comments are unchanged.

mldangelo-oai · 2026-08-15T19:49:30Z

@codex review

chatgpt-codex-connector · 2026-08-15T19:52:09Z

Security review completed. No security issues were found in this pull request.

Reviewed commit: a147e46ca9

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

You comment "@codex security review"
A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a147e46ca9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

mldangelo-oai · 2026-08-15T20:09:51Z

@codex review

chatgpt-codex-connector · 2026-08-15T20:12:43Z

Security review completed. No security issues were found in this pull request.

Reviewed commit: 95b3782aef

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

You comment "@codex security review"
A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 95b3782aef

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

mldangelo-oai · 2026-08-15T20:34:00Z

@codex review

chatgpt-codex-connector · 2026-08-15T20:36:21Z

Codex Review: Didn't find any major issues. 👍

Reviewed commit: ce460fe36a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-08-15T20:37:44Z

Security review completed. No security issues were found in this pull request.

Reviewed commit: ce460fe36a

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

You comment "@codex security review"
A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

…/codex/portfolio-pr-465-20260815

mldangelo-oai · 2026-08-16T10:53:01Z

@codex review

Please review the current head, b9f37a9b17ed5f3c9122b25c6316ba01cc2ffde0.

chatgpt-codex-connector · 2026-08-16T10:55:28Z

Security review completed. No security issues were found in this pull request.

Reviewed commit: b9f37a9b17

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

You comment "@codex security review"
A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b9f37a9b17

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

mldangelo-oai · 2026-08-16T15:38:08Z

@codex review

mldangelo-oai · 2026-08-25T05:18:24Z

@codex review the current head 5f0baaf.

mldangelo-oai · 2026-08-25T05:18:59Z

@codex security review the current head 5f0baaf.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5f0baafd64

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-08-25T05:25:16Z

Security review completed. No security issues were found in this pull request.

Reviewed commit: 5f0baafd64

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

You comment "@codex security review"
A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

mldangelo-oai · 2026-08-25T05:34:09Z

@codex review the current head cb6b36b.

mldangelo-oai · 2026-08-25T05:34:30Z

@codex security review the current head cb6b36b.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cb6b36b452

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-08-25T05:43:03Z

Security review completed. No security issues were found in this pull request.

Reviewed commit: cb6b36b452

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

You comment "@codex security review"
A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

mldangelo-oai · 2026-08-25T06:04:26Z

@codex review the current head 6bca8b1.

mldangelo-oai · 2026-08-25T06:04:50Z

@codex security review the current head 6bca8b1.

chatgpt-codex-connector · 2026-08-25T06:09:36Z

Security review completed. No security issues were found in this pull request.

Reviewed commit: 6bca8b19c2

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

You comment "@codex security review"
A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6bca8b19c2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

mldangelo-oai · 2026-08-25T06:22:01Z

@codex review the current head b4406c7.

mldangelo-oai · 2026-08-25T06:22:38Z

@codex security review the current head b4406c7.

chatgpt-codex-connector · 2026-08-25T06:24:59Z

Codex Review: Didn't find any major issues. You're on a roll.

Reviewed commit: b4406c7f16

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-08-25T06:27:48Z

Security review completed. No security issues were found in this pull request.

Reviewed commit: b4406c7f16

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

You comment "@codex security review"
A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

mldangelo-oai · 2026-08-31T21:35:42Z

@codex review

Please review current head aa383f54446a1914d1bb2d691f4512c937298416 after the additive merge from its updated base, including the conflict resolution and preserved behavior. Focused validation is recorded in the PR description.

mldangelo-oai · 2026-09-03T23:50:07Z

@codex review

Please review head 47a286232cc4e1f01cbee19ea9cb015f0e701584 against main at 6750642c94edce8d60112f816631de05dc10efd6. Combine verifiable final cost accounting with main's live budget increases and completed validation receipts. Keep worker completion required when a spending limit is explicitly requested.

Focused cost tests: 199 passed. Focused API budget/cost and custom-validation checks: 59 passed initially; the live-budget fixture was updated to record completed worker usage and passed on rerun. SDK TypeScript check, plugin bundle generation, changed-file formatting, all three portable plugin source checks, and git diff --check passed. The full suite is left to CI.

chatgpt-codex-connector · 2026-09-03T23:55:01Z

Codex Review: Didn't find any major issues. Swish!

Reviewed commit: 47a286232c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

fix(cost): enforce verifiable scan spending limits

a147e46

github-actions Bot added the bug Something isn't working label Aug 15, 2026

chatgpt-codex-connector Bot reviewed Aug 15, 2026

View reviewed changes

Comment thread sdk/typescript/tests-ts/cost.test.ts Outdated

Comment thread sdk/typescript/src/cost.ts Outdated

fix(cost): reject incomplete final session usage

95b3782

chatgpt-codex-connector Bot reviewed Aug 15, 2026

View reviewed changes

Comment thread sdk/typescript/src/cost.ts Outdated

Comment thread sdk/typescript/src/cost.ts Outdated

fix(cost): verify delegated worker completion and ownership

ce460fe

mldangelo-oai added 6 commits August 15, 2026 23:02

Merge commit '5d1afcd312933121e36dc892dcb12e8d2e3e1de3' into mdangelo…

23e2682

…/codex/portfolio-pr-465-20260815

fix(cost): require completed root evidence for scan budgets

55f73bd

fix(cost): preserve definitive budget overages

1f072db

fix(api): retain definitive budget failure classification

830b696

fix(cost): retain overages discovered during cleanup

f04345e

fix(cost): retain highest usage through budget cleanup

b9f37a9

chatgpt-codex-connector Bot reviewed Aug 16, 2026

View reviewed changes

Comment thread sdk/typescript/src/cost.ts

Comment thread sdk/typescript/tests-ts/cost.test.ts

Comment thread sdk/typescript/src/cost.ts Outdated

mldangelo-oai added 7 commits August 16, 2026 04:14

fix(cost): retain verifiable per-session accounting

9eb6500

fix(cost): respect proven worker ownership

11a702e

fix(cost): exclude unrelated historical accounting evidence

b2fdfa4

fix(cost): reverify late final accounting

ff1827d

fix(cost): retain fresh usage from missing-session reads

59b2598

fix(cost): preserve unpriced completed usage

4c6c807

fix(cost): preserve finalization and usage boundaries

b6f45b6

Verify ownership of every unidentified budgeted rollout

5f0baaf

chatgpt-codex-connector Bot reviewed Aug 25, 2026

View reviewed changes

Comment thread sdk/typescript/src/cost.ts Outdated

Account for equal-total token counter resets

cb6b36b

chatgpt-codex-connector Bot reviewed Aug 25, 2026

View reviewed changes

Comment thread plugins/codex-security/scripts/workbench_scan_usage.py

Comment thread sdk/typescript/src/cost.ts Outdated

Verify complete scan accounting before budget finalization

6bca8b1

chatgpt-codex-connector Bot reviewed Aug 25, 2026

View reviewed changes

Comment thread sdk/typescript/src/cost.ts

Attribute fork-only workers during live budget tracking

b4406c7

mldangelo-oai added 6 commits August 26, 2026 11:47

chore: reconcile scan budgets with main

0846e25

fix: avoid double-counting custom validation usage

962a6b7

refactor: merge main and simplify scan accounting fixtures

5ef6dd2

fix(cost): refresh the cached accounting plugin

250acf1

chore: merge final release packaging updates

488c4dd

Merge main into verifiable scan budgets

aa383f5

chore: resolve PR #465 conflicts with main

47a2862

Uh oh!

Conversation

mldangelo-oai commented Aug 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Testing

Risk and rollout

Public disclosure review

Uh oh!

mldangelo-oai commented Aug 15, 2026

Uh oh!

chatgpt-codex-connector Bot commented Aug 15, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

mldangelo-oai commented Aug 15, 2026

Uh oh!

chatgpt-codex-connector Bot commented Aug 15, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

mldangelo-oai commented Aug 15, 2026

Uh oh!

chatgpt-codex-connector Bot commented Aug 15, 2026

Uh oh!

chatgpt-codex-connector Bot commented Aug 15, 2026

Uh oh!

mldangelo-oai commented Aug 16, 2026

Uh oh!

chatgpt-codex-connector Bot commented Aug 16, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mldangelo-oai commented Aug 16, 2026

Uh oh!

mldangelo-oai commented Aug 25, 2026

Uh oh!

mldangelo-oai commented Aug 25, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot commented Aug 25, 2026

Uh oh!

mldangelo-oai commented Aug 25, 2026

Uh oh!

mldangelo-oai commented Aug 25, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot commented Aug 25, 2026

Uh oh!

mldangelo-oai commented Aug 25, 2026

Uh oh!

mldangelo-oai commented Aug 25, 2026

Uh oh!

chatgpt-codex-connector Bot commented Aug 25, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

mldangelo-oai commented Aug 15, 2026 •

edited

Loading