Skip to content

feat: add VectorStoreFiles API to Facade #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alexmayo
Copy link

@alexmayo alexmayo commented Jun 5, 2025

Add VectorStoreFiles API to facade.

Add the VectorStoreFiles resource.
Copy link
Collaborator

@iBotPeaches iBotPeaches left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I misunderstanding how this works? I don't see vectorStoreFiles in the client which I thought is what this facade points to - https://github.com/openai-php/client/blob/main/src/Contracts/ClientContract.php

Copy link
Collaborator

@iBotPeaches iBotPeaches left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah on investigation. I don't think this is right. You get files from

vectorStores()->files()

or

vectorStores()->batches()

for batches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants