Verbraucher: Ist-Strom = Soll-Strom, wenn Intervall für Schaltbefehl nicht abgelaufen

[LKuemmel]

#3908 (comment)

[Copilot]

🟡 Changes recommended

Reusing allocation maximums as consumer demand can corrupt surplus accounting and incorrectly cancel pending shutdowns.

1 open finding

• Preserve demand during PV allocation to prevent incorrect shutdown reservations · New

What changed in this PR

This PR adjusts consumer switching-interval handling in load control.

Changes:

• Preserves consumer demand during switching intervals.
• Uses interval eligibility for consumer filtering and maximum-demand allocation.
• Updates test setup for eligible consumers.

File	Description
packages/​control/​consumer/​consumer.py	Retains demand during switching intervals.
packages/​control/​algorithm/​surplus_controlled.py	Gates consumer maximum-demand allocation by interval.
packages/​control/​algorithm/​integration_test/​pv_charging_test.py	Updates PV consumer setup.
packages/​control/​algorithm/​integration_test/​instant_charging_test.py	Updates instant-charging consumer setup.
packages/​control/​algorithm/​filter_chargepoints.py	Filters consumers by interval eligibility.
packages/​control/​algorithm/​filter_chargepoints_test.py	Sets interval eligibility in the existing test.

🧠 Review effort: Balanced

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

🟡 Changes recommended

Address the missing consumer gating tests, returned-current coverage, and voltage fallback for consumer current calculation.

1 open finding

• Test measured current return value when interval switching is blocked · New

1 resolved since last review

• Preserve demand during PV allocation to prevent incorrect shutdown reservations

Previously missed (1)

In code that hasn't changed since last review

Add tests for consumer filtering with elapsed and blocked intervals

packages/​control/​algorithm/​filter_chargepoints.py:67

The new consumer-specific filtering behavior is not covered by the updated test: it only sets switch_interval_elapsed = True, so the prior regression case (a consumer with a nonzero/stale required_current while the interval is still blocked) remains untested. Add assertions for both elapsed and non-elapsed consumers so this gating condition cannot regress.

🧠 Review effort: Lite