Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --no-timestamps parameter to build #1638

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

Thaodan
Copy link
Contributor

@Thaodan Thaodan commented Oct 8, 2024

Add --no-timestamps parameter which already exists in build.
Help text copied from build.
Include parameters for the same parameter in buildlog for easier
use.

@pep8speaks
Copy link

pep8speaks commented Oct 8, 2024

Hello @Thaodan! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-10-09 00:23:48 UTC

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 36.29%. Comparing base (f35895d) to head (66b93be).
Report is 51 commits behind head on master.

Files with missing lines Patch % Lines
osc/build.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1638      +/-   ##
==========================================
+ Coverage   36.20%   36.29%   +0.09%     
==========================================
  Files         118      118              
  Lines       19749    19859     +110     
==========================================
+ Hits         7150     7208      +58     
- Misses      12599    12651      +52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Add --no-timestamps parameter which already exists in build.
Help text copied from build.
Include parameters for the same parameter in buildlog for easier
use.
@dmach
Copy link
Contributor

dmach commented Oct 11, 2024

Thanks for the patch.
LGTM, merging.

@dmach dmach merged commit 430ffcf into openSUSE:master Oct 11, 2024
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants