Fix scmsync revisioned checkout #1635
Conversation
|
Hello @adrianschroeter! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-10-08 07:43:29 UTC |
adrianschroeter
force-pushed
the
fix_scmsync_revisioned_checkout
branch
from
c711e79
to
2db0b08
Compare
When specifing a revision to a checkout we need to transfer the information to the bridge to do the right checkout. We also need to take the former git url in case it has changed meanwhile.
adrianschroeter
force-pushed
the
fix_scmsync_revisioned_checkout
branch
from
2db0b08
to
56b8aa6
Compare
dmach
force-pushed
the
fix_scmsync_revisioned_checkout
branch
2 times, most recently
from
e25b12f
to
c670c93
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if revision is not None: | ||
| # search for the git sha sum based on the OBS DISTURL package source revision | ||
| # we need also take into account that the url was different at that point of time | ||
| from .obs_api.scmsync_obsinfo import ScmsyncObsinfo |
Check notice
Code scanning / CodeQL
Cyclic import Note
| @@ -0,0 +1,42 @@ | |||
| import typing | |||
|
|
|||
| from ..util.models import * # pylint: disable=wildcard-import,unused-wildcard-import | |||
Check notice
Code scanning / CodeQL
Cyclic import Note
…msyncObsinfo class
dmach
force-pushed
the
fix_scmsync_revisioned_checkout
branch
from
c670c93
to
5172002
Compare
| def from_api(cls, apiurl: str, project: str, package: str, *, rev: str) -> "ScmsyncObsinfo": | ||
| import urllib.error | ||
| from .. import oscerr | ||
| from ..connection import http_request |
Check notice
Code scanning / CodeQL
Cyclic import Note
| import urllib.error | ||
| from .. import oscerr | ||
| from ..connection import http_request | ||
| from ..core import makeurl |
Check notice
Code scanning / CodeQL
Cyclic import Note
No description provided.