-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix scmsync revisioned checkout #1635
Fix scmsync revisioned checkout #1635
Conversation
Hello @adrianschroeter! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-10-08 07:43:29 UTC |
c711e79
to
2db0b08
Compare
When specifing a revision to a checkout we need to transfer the information to the bridge to do the right checkout. We also need to take the former git url in case it has changed meanwhile.
2db0b08
to
56b8aa6
Compare
e25b12f
to
c670c93
Compare
if revision is not None: | ||
# search for the git sha sum based on the OBS DISTURL package source revision | ||
# we need also take into account that the url was different at that point of time | ||
from .obs_api.scmsync_obsinfo import ScmsyncObsinfo |
Check notice
Code scanning / CodeQL
Cyclic import Note
osc.obs_api.scmsync_obsinfo
@@ -0,0 +1,42 @@ | |||
import typing | |||
|
|||
from ..util.models import * # pylint: disable=wildcard-import,unused-wildcard-import |
Check notice
Code scanning / CodeQL
Cyclic import Note
osc.util.models
…msyncObsinfo class
c670c93
to
5172002
Compare
def from_api(cls, apiurl: str, project: str, package: str, *, rev: str) -> "ScmsyncObsinfo": | ||
import urllib.error | ||
from .. import oscerr | ||
from ..connection import http_request |
Check notice
Code scanning / CodeQL
Cyclic import Note
osc.connection
import urllib.error | ||
from .. import oscerr | ||
from ..connection import http_request | ||
from ..core import makeurl |
Check notice
Code scanning / CodeQL
Cyclic import Note
No description provided.