Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dasd-rules): handle all possible options in rd.dasd (bsc#1230110) (SLE15-SP6:Update) #371

Conversation

aafeijoo-suse
Copy link
Collaborator

The current code only handles (ro) (e.g.: rd.dasd=0.0.0202(ro)), but not the other possible options diag, erplog and failfast [1] (e.g.: rd.dasd=0.0.0202(diag), and their combination using : (e.g.: rd.dasd=0.0.0202(ro:failfast)), which causes a parse error in the next printf:

dracut-cmdline[258]: //lib/dracut/hooks/cmdline/30-parse-dasd.sh: line 39: 16#0203(diag): syntax error in expression (error token is "(diag)")

[1] https://www.ibm.com/docs/en/linux-on-systems?topic=d-setup-4

The current code only handles `(ro)` (e.g.: `rd.dasd=0.0.0202(ro)`), but not the
other possible options `diag`, `erplog` and `failfast` [1] (e.g.:
`rd.dasd=0.0.0202(diag)`, and their combination using `:` (e.g.:
`rd.dasd=0.0.0202(ro:failfast)`), which causes a parse error in the next
`printf`:

```
dracut-cmdline[258]: //lib/dracut/hooks/cmdline/30-parse-dasd.sh: line 39: 16#0203(diag): syntax error in expression (error token is "(diag)")
```

[1] https://www.ibm.com/docs/en/linux-on-systems?topic=d-setup-4
Copy link
Collaborator

@tblume tblume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, for dracut 059, the parse-dasd.sh script shouldn't be in dracut anymore, but in the s390-tools package.

@aafeijoo-suse
Copy link
Collaborator Author

This is 059 shipped for SP6, the changes you mention are only in Tumbleweed and SLFO.

Copy link
Collaborator

@tblume tblume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, you are right.

LGTM

@aafeijoo-suse
Copy link
Collaborator Author

FTR, so we can track this: https://bugzilla.suse.com/show_bug.cgi?id=1221873#c35
Thanks Thomas!

@aafeijoo-suse aafeijoo-suse merged commit 3c2df23 into openSUSE:SLE-15-SP6_Update Sep 27, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants