fix(dracut.sh): do not add device if find_block_device returns an error
#307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rror If `find_block_device` returns an error, the device must not be added to the list of host devices. E.g., a system with /etc mounted as overlay is pushing the empty string '' as host device. ``` //usr/bin/dracut@1658(): readlink -f /etc /usr/bin/dracut@1658(): mp=/etc /usr/bin/dracut@1659(): mountpoint /etc //usr/bin/dracut@1660(): find_block_device /etc //usr/lib/dracut/dracut-functions.sh@366(find_block_device): local _dev _majmin _find_mpt //usr/lib/dracut/dracut-functions.sh@367(find_block_device): _find_mpt=/etc //usr/lib/dracut/dracut-functions.sh@369(find_block_device): [[ '' != yes ]] //usr/lib/dracut/dracut-functions.sh@370(find_block_device): [[ -d /etc/. ]] //usr/lib/dracut/dracut-functions.sh@371(find_block_device): findmnt -e -v -n -o MAJ:MIN,SOURCE --target /etc //usr/lib/dracut/dracut-functions.sh@372(find_block_device): read -r _majmin _dev //usr/lib/dracut/dracut-functions.sh@373(find_block_device): [[ -b overlay ]] //usr/lib/dracut/dracut-functions.sh@384(find_block_device): [[ overlay == *:* ]] //usr/lib/dracut/dracut-functions.sh@372(find_block_device): read -r _majmin _dev //usr/lib/dracut/dracut-functions.sh@372(find_block_device): '[' -n '' ']' //usr/lib/dracut/dracut-functions.sh@389(find_block_device): return 1 //usr/lib/dracut/dracut-functions.sh@393(find_block_device): [[ ! -f /etc/fstab ]] //usr/lib/dracut/dracut-functions.sh@395(find_block_device): findmnt -e --fstab -v -n -o MAJ:MIN,SOURCE --target /etc //usr/lib/dracut/dracut-functions.sh@396(find_block_device): read -r _majmin _dev //usr/lib/dracut/dracut-functions.sh@397(find_block_device): [[ -n '' ]] //usr/lib/dracut/dracut-functions.sh@398(find_block_device): _dev=overlay //usr/lib/dracut/dracut-functions.sh@399(find_block_device): unset _majmin //usr/lib/dracut/dracut-functions.sh@401(find_block_device): [[ -b overlay ]] //usr/lib/dracut/dracut-functions.sh@410(find_block_device): [[ overlay == *:* ]] //usr/lib/dracut/dracut-functions.sh@396(find_block_device): read -r _majmin _dev //usr/lib/dracut/dracut-functions.sh@396(find_block_device): '[' -n '' ']' //usr/lib/dracut/dracut-functions.sh@415(find_block_device): return 1 //usr/lib/dracut/dracut-functions.sh@418(find_block_device): return 1 /usr/bin/dracut@1660(): _dev= //usr/bin/dracut@1661(): readlink -f /dev/block/ /usr/bin/dracut@1661(): _bdev=/dev/block /usr/bin/dracut@1662(): [[ -b /dev/block ]] /usr/bin/dracut@1663(): [[ /etc == \/ ]] /usr/bin/dracut@1664(): push_host_devs '' ```
Check at least that the arguments are not an empty string.
aafeijoo-suse
changed the title
find_block_device returns an error
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
find_block_devicereturns an error, the device must not be added to the list of host devices. E.g., a MicroOS system with/etcmounted as overlay is pushing the empty string '' as host device, leading to incorrect results from functions called later which are expecting block devices (i.e.get_persistent_devandget_maj_min).