Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dracut.sh): skip README for AMD microcode generation (bsc#1217083) #302

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

aafeijoo-suse
Copy link
Collaborator

Copy link
Collaborator

@tblume tblume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question.
According to https://bugzilla.suse.com/show_bug.cgi?id=1217083#c23 the README is present is SP5 and older.
That would be <=dracut 055.
So, the submission to 059 doesn't seem to be really necessary.
Are you submitting to 059 just for completeness and do the submission for the older versions later?

@aafeijoo-suse
Copy link
Collaborator Author

Just a question. According to https://bugzilla.suse.com/show_bug.cgi?id=1217083#c23 the README is present is SP5 and older. That would be <=dracut 055.

I only found this problem in SP5, but not in the latest SP3 version (ucode-amd-20210208-150300.4.10.1) and SP4 version (ucode-amd-20220509-150400.4.22.1). Besides, SP3 is LTSS and SP4 enters LTSS in January 2024, so I don't think the version of the kernel-firmware package will be increased.

So, the submission to 059 doesn't seem to be really necessary. Are you submitting to 059 just for completeness and do the submission for the older versions later?

I realized the submission for 059 may be necessary if the user is not getting the AMD ucode from the official SUSE repo, or if he is using a custom firmware directory (--fwdir option). In that sense, it doesn't hurt to fix Factory, and maybe SP6.

What do you think? Should we fix SP6/4/3?

@tblume
Copy link
Collaborator

tblume commented Nov 24, 2023

I only found this problem in SP5, but not in the latest SP3 version (ucode-amd-20210208-150300.4.10.1) and SP4 version (ucode-amd-20220509-150400.4.22.1). Besides, SP3 is LTSS and SP4 enters LTSS in January 2024, so I don't think the version of the kernel-firmware package will be increased.

Ah ok.

I realized the submission for 059 may be necessary if the user is not getting the AMD ucode from the official SUSE repo, or if he is using a custom firmware directory (--fwdir option). In that sense, it doesn't hurt to fix Factory, and maybe SP6.

Ok, thanks for the background.

What do you think? Should we fix SP6/4/3?

I'd say so for the sake of consistency.
And you are right, it doesn't hurt having it.

@aafeijoo-suse aafeijoo-suse merged commit ba7b6a3 into openSUSE:SUSE/059 Nov 27, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AuthenticAMD.bin includes README, breaking early loading
2 participants