Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct network device naming (bsc#1192986) #290

Conversation

tblume
Copy link
Collaborator

@tblume tblume commented Oct 20, 2023

Make the rule for persistent net device naming default in SLES. Keep the predictable names as fallback if 70-persistent-net.rules is not present but a network module is added to the initrd. Make sure that either persistent or predictable naming is applied, but never both.

This pull request changes...

This is for v055

Changes

Checklist

  • [ x ] I have tested it locally
  • I have reviewed and updated any documentation if relevant
  • I am providing new code and test(s) for it

Fixes #

@tblume tblume requested a review from aafeijoo-suse as a code owner October 20, 2023 14:23
@tblume tblume force-pushed the fix-persistent-net-rules-application-bsc1192986-055 branch 2 times, most recently from 3bd727e to cdba629 Compare October 20, 2023 14:59
@tblume tblume force-pushed the fix-persistent-net-rules-application-bsc1192986-055 branch from cdba629 to b9e04ac Compare October 23, 2023 06:18
@tblume tblume force-pushed the fix-persistent-net-rules-application-bsc1192986-055 branch from b9e04ac to bd230d2 Compare October 23, 2023 07:38
@tblume tblume force-pushed the fix-persistent-net-rules-application-bsc1192986-055 branch from bd230d2 to e842f55 Compare October 23, 2023 12:53
Make the rule for persistent net device naming default in SLES.
Keep the predictable names as fallback if 70-persistent-net.rules is not
present but a network module is added to the initrd.
Make sure that either persistent or predictable naming is applied, but never
both.
@tblume tblume force-pushed the fix-persistent-net-rules-application-bsc1192986-055 branch from e842f55 to ad3d851 Compare October 23, 2023 13:00
Copy link
Collaborator

@aafeijoo-suse aafeijoo-suse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, thanks!

@aafeijoo-suse aafeijoo-suse merged commit 8d525d3 into openSUSE:SUSE/055 Nov 13, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants