-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dataset-specific JSON/TOML configuration #1646
base: dev
Are you sure you want to change the base?
Conversation
3d5b70a
to
37d57ab
Compare
and is interpreted as a regular expression against which the dataset name | ||
(full path or path within an iteration) must match.)END"; | ||
auto throw_up = [&](std::string const &additional_info, | ||
auto &&...additional_path) { |
Check notice
Code scanning / CodeQL
Unused local variable Note
and is interpreted as a regular expression against which the dataset name | ||
(full path or path within an iteration) must match.)END"; | ||
auto throw_up = [&](std::string const &additional_info, | ||
auto &&...additional_path) { |
Check notice
Code scanning / CodeQL
Unused static variable Note
and is interpreted as a regular expression against which the dataset name | ||
(full path or path within an iteration) must match.)END"; | ||
auto throw_up = [&](std::string const &additional_info, | ||
auto &&...additional_path) { |
Check notice
Code scanning / CodeQL
Declaration hides parameter Note
parameter of the same name
|
||
namespace | ||
{ | ||
auto readPattern( |
Check warning
Code scanning / CodeQL
Poorly documented large function Warning
c95a953
to
68dc005
Compare
std::string merge_impl( | ||
std::string const &defaultValue, | ||
std::string const &overwrite, | ||
MPI_Comm_t &&...comm) |
Check notice
Code scanning / CodeQL
Unused local variable Note
std::string merge_impl( | ||
std::string const &defaultValue, | ||
std::string const &overwrite, | ||
MPI_Comm_t &&...comm) |
Check notice
Code scanning / CodeQL
Unused static variable Note
c0f942e
to
fb7a28e
Compare
fb7a28e
to
5f77a13
Compare
5f77a13
to
64b006d
Compare
might also be good for documentation purposes as JSON is more widely known
64b006d
to
8852258
Compare
This was initially prototyped in PIConGPU, search for "extended format for JSON options" on this documentation page.
This moves that functionality over into openPMD.
Look at the diff on
examples/13_write_dynamic_configuration.cpp
for an example use case.Bringing this to openPMD makes this functionality available in codes other than PIConGPU, and makes it available from TOML as well as from JSON.
TODO: