Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix use after free in ADIOS1IOHandler #1224

Merged
merged 1 commit into from
Mar 13, 2022
Merged

Fix use after free in ADIOS1IOHandler #1224

merged 1 commit into from
Mar 13, 2022

Conversation

franzpoeschel
Copy link
Contributor

Extracted from #1197

There is currently a (low-key) use after free in ADIOS1, happening if a user calls loadChunk() without storing the buffer. #1197 will add a test.

ax3l
ax3l approved these changes Mar 13, 2022
View reviewed changes
Copy link
Member

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 ✨

@ax3l ax3l self-assigned this Mar 13, 2022
@ax3l ax3l merged commit 272b137 into openPMD:dev Mar 13, 2022
@ax3l ax3l added this to the 0.14.5 milestone Mar 13, 2022
@ax3l
Copy link
Member

ax3l commented May 25, 2022

I have problems backporting this to release-0.14.5 branch due to the change in CommonADIOS1IOHandler.hpp/cpp

@ax3l ax3l modified the milestones: 0.14.5, 0.14.6 May 25, 2022
@franzpoeschel franzpoeschel mentioned this pull request May 30, 2022
Merged
@ax3l ax3l modified the milestones: 0.14.6, 0.14.5 Jun 6, 2022
@ax3l
Copy link
Member

ax3l commented Jun 6, 2022

Applied to 0.14.5 via ax3l#6 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ax3l ax3l ax3l approved these changes

Assignees

@ax3l ax3l

Labels
affects latest release backend: ADIOS1 bug
Projects
None yet
Milestone
0.14.5
Development

Successfully merging this pull request may close these issues.
2 participants
@franzpoeschel @ax3l