fix #2472 : refactoring about us viewmodal #2481
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NiranjanNlc
force-pushed
the
aboutUsRefactor
branch
from
2755fdc to
a5d5713
Compare
PratyushSingh07
requested changes
Jan 9, 2024
There was a problem hiding this comment.
change your PR & commit message to something that follows our guidelines. For this you can refer CONTRIBUTION.md . Also format your code if you havent already. I am converting this PR to draft. You can make it readu for review after you have implemented the changes
app/src/main/java/org/mifos/mobile/repositories/AboutUsRepository.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/mifos/mobile/repositories/AboutUsRepositoryImpl.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/mifos/mobile/ui/about/AboutUsViewModel.kt
Outdated
Show resolved
Hide resolved
NiranjanNlc
changed the title
NiranjanNlc
changed the title
NiranjanNlc
commented
Jan 9, 2024
app/src/main/java/org/mifos/mobile/repositories/AboutUsRepository.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/mifos/mobile/repositories/AboutUsRepositoryImpl.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/mifos/mobile/ui/about/AboutUsViewModel.kt
Outdated
Show resolved
Hide resolved
NiranjanNlc
force-pushed
the
aboutUsRefactor
branch
from
a5d5713 to
bcfcf59
Compare
|
Implemented the changes as you suggested @PratyushSingh07 |
|
We are focusing on jetpack compose implementation, this will be useless to implement you are free to send PR for converting xml to compose. |
Thanks @therajanmaurya for feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2472
Same UI shown after refactoring
Please make sure these boxes are checked before submitting your pull request - thanks!
Apply the
AndroidStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.