fix: Improve clarity and correctness in showFilterDialog #2465
Conversation
|
@PratyushSingh07 review this....Also there was an another issue in this should i make another issue or solve in this |
What's the other issue? |
|
@PratyushSingh07 The contact us is going to top if there are no transactions it should be at the bottom |
Well I personally don't think this is an issue. In my opinion it would have looked odd if it was at the bottom. Why don't you try to change this behaviour and then we can compare which version looks better. Implement it in this PR itself and incase it doesn't look good you can always reset back to the previous commit |
|
@PratyushSingh07 Okay! |
|
|
Hmm ... Your call @Thanush66 I like both of them 😅 |
|
@PratyushSingh07 ig the second looks cleaner , Its just my opinion..! |
|
Alright let's go with this |
PratyushSingh07
changed the title
PratyushSingh07
changed the title
|
|
||
| </LinearLayout> | ||
| android:gravity="center" | ||
| android:text="No transactions to display" |
There was a problem hiding this comment.
add this to strings.xml
There was a problem hiding this comment.
How many times will I have to tell you not to resolve conversations on your own ?
There was a problem hiding this comment.
Oops! My bad didn't know that reviewer should close them...
app/src/main/java/org/mifos/mobile/ui/fragments/SavingAccountsTransactionFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/mifos/mobile/ui/fragments/SavingAccountsTransactionFragment.kt
Outdated
Show resolved
Hide resolved
|
@PratyushSingh07 Done with changes.....Any more changes...? |
| @@ -298,84 +299,70 @@ class SavingAccountsTransactionFragment : BaseFragment() { | |||
| /** | |||
| * Shows a filter dialog | |||
| */ | |||
| private lateinit var filterBinding: LayoutFilterDialogBinding | |||
There was a problem hiding this comment.
make this global and change the name of variable to layoutFilterDialogBinding
There was a problem hiding this comment.
Okay...needed to change the first letter to Lowercase..?
| filterBinding = LayoutFilterDialogBinding.inflate(layoutInflater) | ||
| val dialogView = filterBinding.root | ||
|
|
||
| val checkBoxPeriod: AppCompatCheckBox? = filterBinding.cbSelect |
There was a problem hiding this comment.
do we need to explicitly declare AppCompatCheckBox ?
ghost
closed this by deleting the head repository
Fixes #2457
Please Add Screenshots If there are any UI changes.
Screen_recording_20240101_175042.mp4
Please make sure these boxes are checked before submitting your pull request - thanks!
Apply the
AndroidStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.