fix: Update Fastlane & Sync More Directories #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niyajali
commented
Jan 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes significant changes to the sync workflow, Fastlane configuration, and build logic. The most important changes include enhancements to the sync workflow, the addition of a comprehensive Fastlane configuration guide, and updates to build logic identifiers.
Sync Workflow Enhancements:
.github/workflows/sync-cmp-dirs.yaml: Updated the sync workflow to include additional directories and files, added safety checks, and improved error handling. The workflow now creates a pull request with more detailed change logs.Fastlane Configuration:
Fastlane Configuration.md: Added a detailed guide for Fastlane setup, including prerequisites, setup instructions, environment variables, available lanes, version generation, release notes generation, CI/CD integration, best practices, and troubleshooting.Build Logic Updates:
build-logic/convention/build.gradle.kts: Changed group and plugin IDs fromorg.mifostoorg.conventionto reflect the new naming convention. (Feaa7918L1R1, build-logic/convention/build.gradle.ktsL45-R90)build-logic/convention/src/main/kotlin/AndroidApplicationComposeConventionPlugin.kt: Updated import statements to use the neworg.conventionpackage.build-logic/convention/src/main/kotlin/AndroidApplicationConventionPlugin.kt: Updated import statements and applied plugins to use the neworg.conventionpackage. [1] [2]build-logic/convention/src/main/kotlin/AndroidApplicationFlavorsConventionPlugin.kt: Updated import statements to use the neworg.conventionpackage.build-logic/convention/src/main/kotlin/CMPFeatureConventionPlugin.kt: Updated import statements to use the neworg.conventionpackage.Documentation Updates:
README.md: Updated to reflect the enhanced directory sync system, including new components and safety features. Added sections for Fastlane configuration, using the sync system, and best practices for sync management. [1] [2]These changes aim to improve the automation and configuration processes, ensuring a more robust and maintainable codebase.