Survey-Question-Logic-Implemented #2262
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsPronay
suggested changes
Dec 9, 2024
Comment on lines
85
to
86
| viewModel: SurveySubmitViewModel = hiltViewModel(), | ||
| queViewModel: SurveyQuestionViewModel = hiltViewModel(), |
There was a problem hiding this comment.
submitViewmodel
quesViewmodel / questionViewmodel
Comment on lines
89
to
90
| val uiState2 by queViewModel.surveyQuestionUiState.collectAsStateWithLifecycle() | ||
| val uiState by viewModel.surveySubmitUiState.collectAsStateWithLifecycle() |
There was a problem hiding this comment.
choose an appropriate name, don't just do uiState , uiState2. its confusing,
| @@ -79,68 +81,107 @@ import java.util.Date | |||
| @Composable | |||
| internal fun SurveyQuestionScreen( | |||
| navigateBack: () -> Unit, | |||
| survey: Survey?, | |||
| id: Int, | |||
There was a problem hiding this comment.
dont pass id in here, retrieve it from viewmodel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes JIRA
Please Add Screenshots If there are any UI changes.
survey_question_video.mp4
Please make sure these boxes are checked before submitting your pull request - thanks!
Apply the
MifosStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.