Applied Spotless and Detekt to the "feature-datatable" module. MIFOSAC-282 #2256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply Spotless and Detekt to the "feature-datatable" module.
|
Sir, please merge this PR this is done |
|
@Aditya3815 please fix merge conflicts |
Aditya3815
force-pushed
the
Android-client
branch
from
e96f623 to
54aa6bc
Compare
itsPronay
suggested changes
Dec 12, 2024
| ) { | ||
| Box( | ||
| modifier = Modifier | ||
| modifier = modifier // Pass the modifier here |
There was a problem hiding this comment.
can you remove comments here?
| ) { paddingValues -> | ||
| Column(modifier = Modifier.padding(paddingValues)) { | ||
| Column(modifier = modifier.padding(paddingValues)) { // Use the passed Modifier here |
|
Sure
…On Thu, Dec 12, 2024 at 3:14 PM Pronay Sarker ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In
feature/data-table/src/main/java/com/mifos/feature/dataTable/dataTable/DataTableScreen.kt
<#2256 (comment)>
:
> ) {
Box(
- modifier = Modifier
+ modifier = modifier // Pass the modifier here
can you remove comments here?
------------------------------
In
feature/data-table/src/main/java/com/mifos/feature/dataTable/dataTableData/DataTableDataScreen.kt
<#2256 (comment)>
:
> ) { paddingValues ->
- Column(modifier = Modifier.padding(paddingValues)) {
+ Column(modifier = modifier.padding(paddingValues)) { // Use the passed Modifier here
here as well
—
Reply to this email directly, view it on GitHub
<#2256 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUGJNUXW2HPM7IBR3YBOIGD2FFLILAVCNFSM6AAAAABTGM6BQWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDIOJYGY2DAOJYGY>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply Spotless and Detekt to the "feature-datatable" module.
Fixes https://mifosforge.jira.com/browse/MIFOSAC-282
Please Add Screenshots If there are any UI change
Please make sure these boxes are checked before submitting your pull request - thanks!
Apply the
MifosStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.