Bug + Refactor: Features-> Auth Module . #2239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Darkeye14
changed the title
WhatsApp.Video.2024-11-14.at.23.46.50_9699878a.mp4 |
itsPronay
reviewed
Nov 14, 2024
Comment on lines
46
to
58
| fun NavController.navigateToMainGraph(){ | ||
| val options = navOptions { | ||
| popUpTo(graph.findStartDestination().id) { | ||
| saveState = false | ||
| } | ||
| launchSingleTop = true | ||
| restoreState = false | ||
| } | ||
| navigate(MifosNavGraph.MAIN_GRAPH , options) | ||
|
|
||
|
|
||
|
|
||
| } |
There was a problem hiding this comment.
we don't need it.
The error can be fixed by changing the Navroute of MifosNavGraph.MainGraph or passcodegraph.mainscreengraph
itsPronay
reviewed
Nov 15, 2024
Comment on lines
42
to
44
| composable(MifosNavGraph.MAIN_GRAPH){ | ||
| HomeNavigation() | ||
| } |
There was a problem hiding this comment.
why are we adding this here? we already have one called homeGraph
…odule-CleanUp # Conflicts: # mifosng-android/src/main/java/com/mifos/mifosxdroid/AndroidClient.kt
itsPronay
suggested changes
Nov 19, 2024
Comment on lines
82
to
93
| <activity | ||
| android:name=".activity.setting.SettingsActivity" | ||
| android:label="@string/settings" | ||
| android:parentActivityName=".activity.home.HomeActivity" | ||
| android:screenOrientation="portrait"> | ||
| <meta-data | ||
| android:name="android.support.PARENT_ACTIVITY" | ||
| android:value=".activity.home.HomeActivity" /> | ||
| </activity> | ||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
we already cleaned up feature settings . why are we adding this?
Comment on lines
77
to
109
| <fragment | ||
| android:id="@+id/checkerInboxTasksFragment" | ||
| android:name="com.mifos.mifosxdroid.online.checkerinbox.CheckerInboxTasksFragment" | ||
| android:label="CheckerInboxTasksFragment"> | ||
| <action | ||
| android:id="@+id/action_checkerInboxTasksFragment_to_checkerInboxFragment" | ||
| app:destination="@id/checkerInboxFragment" /> | ||
| </fragment> | ||
|
|
||
|
|
||
| <fragment | ||
| android:id="@+id/checkerInboxFragment" | ||
| android:name="com.mifos.mifosxdroid.online.checkerinbox.CheckerInboxFragment" | ||
| android:label="CheckerInboxFragment" /> | ||
|
|
||
|
|
||
| <fragment | ||
| android:id="@+id/individualCollectionSheetFragment" | ||
| android:name="com.mifos.mifosxdroid.online.collectionsheetindividual.IndividualCollectionSheetFragment" | ||
| android:label="IndividualCollectionSheetFragment"> | ||
|
|
||
| <action | ||
| android:id="@+id/action_individualCollectionSheetFragment_to_individualCollectionSheetDetailsFragment" | ||
| app:destination="@id/individualCollectionSheetDetailsFragment" /> | ||
|
|
||
| </fragment> | ||
|
|
||
|
|
||
| <fragment | ||
| android:id="@+id/generateCollectionSheetFragment" | ||
| android:name="com.mifos.mifosxdroid.online.generatecollectionsheet.GenerateCollectionSheetFragment" | ||
| android:label="GenerateCollectionSheetFragment" /> | ||
|
|
There was a problem hiding this comment.
Why are we adding this again? Wasn't it already removed during the previous cleanup process?
Comment on lines
146
to
186
| <fragment | ||
| android:id="@+id/individualCollectionSheetDetailsFragment" | ||
| android:name="com.mifos.mifosxdroid.online.collectionsheetindividualdetails.IndividualCollectionSheetDetailsFragment" | ||
| android:label="IndividualCollectionSheetDetailsFragment"> | ||
| <argument | ||
| android:name="sheet" | ||
| app:argType="com.mifos.core.objects.collectionsheet.IndividualCollectionSheet" /> | ||
| <argument | ||
| android:name="actualDisbursementDate" | ||
| app:argType="string" /> | ||
| <argument | ||
| android:name="transactionDate" | ||
| app:argType="string" /> | ||
| <action | ||
| android:id="@+id/action_individualCollectionSheetDetailsFragment_to_paymentDetailsFragment" | ||
| app:destination="@id/paymentDetailsFragment" /> | ||
| </fragment> | ||
| <fragment | ||
| android:id="@+id/paymentDetailsFragment" | ||
| android:name="com.mifos.mifosxdroid.online.collectionsheetindividualdetails.PaymentDetailsFragment" | ||
| android:label="PaymentDetailsFragment"> | ||
| <argument | ||
| android:name="position" | ||
| app:argType="integer" /> | ||
| <argument | ||
| android:name="payload" | ||
| app:argType="com.mifos.core.network.model.IndividualCollectionSheetPayload" /> | ||
| <argument | ||
| android:name="paymentTypeList" | ||
| app:argType="string[]" /> | ||
| <argument | ||
| android:name="loanAndClientName" | ||
| app:argType="com.mifos.core.objects.collectionsheet.LoanAndClientName" /> | ||
| <argument | ||
| android:name="paymentTypeOptions" | ||
| app:argType="com.mifos.core.objects.accounts.loan.PaymentTypeOptions[]" /> | ||
| <argument | ||
| android:name="clientId" | ||
| app:argType="integer" /> | ||
| </fragment> | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #Issue_Number
MIFOSAC-277
1)Fixes Post Login navigation issue.
2) CleanUp of Auth Module
3)Applying Spotless and detekt
Please Add Screenshots If there are any UI changes.
Please make sure these boxes are checked before submitting your pull request - thanks!
Apply the
MifosStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.