Bug + Refactor : Auth Module #2237
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsPronay
suggested changes
Nov 13, 2024
Comment on lines
40
to
43
| }, | ||
| onSuccessNavigate = { | ||
| startActivity(Intent(this, HomeActivity::class.java)) | ||
| finish() |
There was a problem hiding this comment.
why are we adding this? In compose we only need one activity, this LoginActivity.kt file should be removed
There was a problem hiding this comment.
I have removed it in #2235 bhai. Hold on.
There was a problem hiding this comment.
@Darkeye14 Login comes under auth.. Anything that is not related to settings-module should not get deleted in settingsPR
Comment on lines
33
to
36
| navigatePasscode = {}, | ||
| navigateHome = navController::navigateHome, | ||
| updateServerConfig = {} | ||
| updateServerConfig = {}, | ||
| onSuccessNavigate = navController ::navigateHome |
# Conflicts: # feature/auth/src/main/java/com/mifos/feature/auth/login/LoginScreen.kt # feature/auth/src/main/java/com/mifos/feature/auth/login/LoginUiState.kt # feature/auth/src/main/java/com/mifos/feature/auth/navigation/AuthNavigation.kt
itsPronay
suggested changes
Nov 13, 2024
| if (prefManager.getPassCodeStatus()) { | ||
| _loginUiState.value = LoginUiState.HomeActivityIntent | ||
| } else { | ||
| _loginUiState.value = LoginUiState.PassCodeActivityIntent | ||
| } | ||
| _loginUiState.value = LoginUiState.HomeActivityIntent |
There was a problem hiding this comment.
don't do this. Fix authNavgraph of Login Screen
There was a problem hiding this comment.
Bhai, i think this could be the right logic. lets connect in gmeet whenever you are free
|
I'll be closing this Now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #Issue_Number
MIFOSAC-277
1)Fixes Post Login navigation issue.
2) CleanUp of Auth Module
3)Applying Spotless and detekt
Please Add Screenshots If there are any UI changes.
WhatsApp.Video.2024-11-13.at.20.17.31_45a044b3.mp4
Please make sure these boxes are checked before submitting your pull request - thanks!
Apply the
MifosStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.