refactor: refactor checker inbox & task to jetpack compose with multi module #2086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
therajanmaurya
requested changes
Apr 3, 2024
...om/sparklead/feature/checker_inbox_task/checker_inbox_and_task/di/CheckerInboxTasksModule.kt
Outdated
Show resolved
Hide resolved
...ad/feature/checker_inbox_task/checker_inbox_and_task/presentation/CheckerInboxTasksScreen.kt
Outdated
Show resolved
Hide resolved
...ad/feature/checker_inbox_task/checker_inbox_and_task/presentation/CheckerInboxTasksScreen.kt
Outdated
Show resolved
Hide resolved
| option = "Client Approval", | ||
| badge = "0" | ||
| ) { | ||
|
|
There was a problem hiding this comment.
why onclick is missing here?
There was a problem hiding this comment.
Till now there is no next screen for that feature.
| fun CheckerInboxTasksScreen(onBackPressed: () -> Unit, checkerInbox: () -> Unit) { | ||
|
|
||
| val checkerInboxTasksViewModel: CheckerInboxTasksViewModel = hiltViewModel() | ||
| val state = checkerInboxTasksViewModel.checkerInboxTasksUiState.collectAsState().value |
There was a problem hiding this comment.
Don't use collectAsState().value instead use collectAsStateWithLifecycle() every where
|
|
||
| val checkerInboxTasksViewModel: CheckerInboxTasksViewModel = hiltViewModel() | ||
| val state = checkerInboxTasksViewModel.checkerInboxTasksUiState.collectAsState().value | ||
| val isRefreshing by checkerInboxTasksViewModel.isRefreshing.collectAsState() |
There was a problem hiding this comment.
Don't use collectAsState() instead use collectAsStateWithLifecycle() every where
therajanmaurya
requested changes
Apr 3, 2024
| this, factory | ||
| ).get(CheckerInboxTasksViewModel::class.java) | ||
|
|
||
| viewModel.getCheckerTasks().observe(viewLifecycleOwner, |
There was a problem hiding this comment.
I don't see this initial load of getCheckerTasks() and getRescheduleLoanTasks() in composable screen
There was a problem hiding this comment.
I have created one GetCheckerInboxBadgesUseCase which consist both.
therajanmaurya
approved these changes
Apr 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2082
XML Screen
Record_2024-04-16-22-22-28.mp4
Jetpack Compose
Record_2024-04-17-19-34-50.mp4