Refactor - GroupList screen to compose UI #2079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@therajanmaurya please review my pr |
therajanmaurya
requested changes
Mar 15, 2024
core/designsystem/src/main/java/com/mifos/core/designsystem/component/MifosFAB.kt
Outdated
Show resolved
Hide resolved
core/designsystem/src/main/java/com/mifos/core/designsystem/component/MifosSelection.kt
Outdated
Show resolved
Hide resolved
core/designsystem/src/main/java/com/mifos/core/designsystem/theme/Dimensions.kt
Outdated
Show resolved
Hide resolved
core/network/src/main/java/com/mifos/core/network/datamanager/DataManagerGroups.kt
Outdated
Show resolved
Hide resolved
feature/groups/src/main/java/com/mifos/feature/groupsList/di/GroupsListModule.kt
Outdated
Show resolved
Hide resolved
feature/groups/src/main/java/com/mifos/feature/groupsList/presentation/GroupsListScreen.kt
Outdated
Show resolved
Hide resolved
feature/groups/src/main/java/com/mifos/feature/groupsList/presentation/GroupsListScreen.kt
Outdated
Show resolved
Hide resolved
feature/groups/src/main/java/com/mifos/feature/groupsList/presentation/GroupsListScreen.kt
Outdated
Show resolved
Hide resolved
feature/groups/src/main/java/com/mifos/feature/groupsList/presentation/GroupsListScreen.kt
Outdated
Show resolved
Hide resolved
feature/groups/src/main/java/com/mifos/feature/groupsList/presentation/GroupsListState.kt
Outdated
Show resolved
Hide resolved
|
@therajanmaurya kindly review again this pr |
|
@therajanmaurya kindly review my PR |
therajanmaurya
requested changes
Apr 3, 2024
feature/groups/src/main/java/com/mifos/feature/groupsList/di/GroupModule.kt
Outdated
Show resolved
Hide resolved
feature/groups/src/main/java/com/mifos/feature/groupsList/presentation/GroupsListScreen.kt
Outdated
Show resolved
Hide resolved
feature/groups/src/main/java/com/mifos/feature/groupsList/presentation/GroupsListScreen.kt
Outdated
Show resolved
Hide resolved
feature/groups/src/main/java/com/mifos/feature/groupsList/presentation/GroupsListScreen.kt
Outdated
Show resolved
Hide resolved
feature/groups/src/main/java/com/mifos/feature/groupsList/presentation/GroupsListScreen.kt
Outdated
Show resolved
Hide resolved
feature/groups/src/main/java/com/mifos/feature/groupsList/presentation/GroupsListScreen.kt
Outdated
Show resolved
Hide resolved
feature/groups/src/main/java/com/mifos/feature/groupsList/presentation/GroupsListScreen.kt
Outdated
Show resolved
Hide resolved
feature/groups/src/main/java/com/mifos/feature/groupsList/presentation/GroupsListViewModel.kt
Outdated
Show resolved
Hide resolved
- Added Unit & Ui Test Classes
|
@therajanmaurya kindly review my changes |
|
@therajanmaurya resolved conflicts, kindly review my changes. |
|
And move the |
|
Move |
Aditya-gupta99
requested changes
May 12, 2024
There was a problem hiding this comment.
@niyajali Can you make the changes listed so that we can merge this PR?
core/designsystem/src/main/java/com/mifos/core/designsystem/component/MifosSweetError.kt
Show resolved
Hide resolved
# Conflicts: # core/common/build.gradle.kts # core/designsystem/build.gradle.kts # core/designsystem/src/main/java/com/mifos/core/designsystem/component/MifosProgressIndicator.kt # core/designsystem/src/main/java/com/mifos/core/designsystem/component/MifosSweetError.kt # mifosng-android/build.gradle.kts # settings.gradle.kts
- Fixed dependencies declaration - Moved files to respective module - Applied convention plugins - Fixed lint issue
# Conflicts: # build-logic/convention/src/main/kotlin/AndroidFeatureConventionPlugin.kt # core/common/build.gradle.kts # core/data/build.gradle.kts # core/datastore/build.gradle.kts # core/designsystem/build.gradle.kts # core/domain/build.gradle.kts # core/testing/build.gradle.kts # core/testing/src/main/java/com/mifos/core/testing/MifosTestRunner.kt # core/ui/build.gradle.kts # feature/collection-sheet/build.gradle.kts # gradle/libs.versions.toml # mifosng-android/build.gradle.kts # settings.gradle.kts
therajanmaurya
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2074
Close - MIFOSAC-165
Please Add Screenshots If there are any UI changes.
Screen_recording_20240408_100100.mp4
Screen_recording_20240408_101338.mp4
Please make sure these boxes are checked before submitting your pull request - thanks!
Apply the
MifosStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.