refactor: refactor client list screen to compose with clean arch, multi module and paging3 #2070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@therajanmaurya Please review this PR. |
|
@Aditya-gupta99 have you introduced the Realm in this PR, if yes then we are not going to use any ORM, we will be focusing on Room now |
|
@therajanmaurya We're building an android client to support Kotlin multiplatform mobile, but Room doesn't support KMM, whereas realm is a better option to migrate with. |
Aditya-gupta99
changed the title
|
@therajanmaurya Fixed this PR by implementing DBflow instead of realm and migrating the entire code base to multi module. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2069
Record_2024-02-21-20-15-03.mp4
Apply the
MifosStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.