refactor: splash cleanup (#2236)

* splash cleanup

fix errors

* fixed conflicts

feature/splash/build.gradle.kts

@@ -1,3 +1,12 @@
+/*
+ * Copyright 2024 Mifos Initiative
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at https://mozilla.org/MPL/2.0/.
+ *
+ * See https://github.com/openMF/android-client/blob/master/LICENSE.md
+ */
 plugins {
     alias(libs.plugins.mifos.android.feature)
     alias(libs.plugins.mifos.android.library.compose)

feature/splash/src/androidTest/java/com/mifos/feature/splash/ExampleInstrumentedTest.kt

@@ -1,13 +1,20 @@
+/*
+ * Copyright 2024 Mifos Initiative
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at https://mozilla.org/MPL/2.0/.
+ *
+ * See https://github.com/openMF/android-client/blob/master/LICENSE.md
+ */
 package com.mifos.feature.splash
 
-import androidx.test.platform.app.InstrumentationRegistry
 import androidx.test.ext.junit.runners.AndroidJUnit4
-
+import androidx.test.platform.app.InstrumentationRegistry
+import junit.framework.TestCase.assertEquals
 import org.junit.Test
 import org.junit.runner.RunWith
 
-import org.junit.Assert.*
-
 /**
  * Instrumented test, which will execute on an Android device.
  *
@@ -21,4 +28,4 @@ class ExampleInstrumentedTest {
         val appContext = InstrumentationRegistry.getInstrumentation().targetContext
         assertEquals("com.mifos.feature.splash.test", appContext.packageName)
     }
-}
+}

feature/splash/src/main/AndroidManifest.xml

@@ -1,4 +1,13 @@
 <?xml version="1.0" encoding="utf-8"?>
+<!--
+    Copyright 2024 Mifos Initiative
+
+    This Source Code Form is subject to the terms of the Mozilla Public License, v. 2.0.
+    If a copy of the MPL was not distributed with this file,
+    You can obtain one at https://mozilla.org/MPL/2.0/.
+
+    See https://github.com/openMF/android-client/blob/master/LICENSE.md
+-->
 <manifest xmlns:android="http://schemas.android.com/apk/res/android">
 
 </manifest>

feature/splash/src/main/java/com/mifos/feature/splash/navigation/SplashNavigation.kt

@@ -1,3 +1,12 @@
+/*
+ * Copyright 2024 Mifos Initiative
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at https://mozilla.org/MPL/2.0/.
+ *
+ * See https://github.com/openMF/android-client/blob/master/LICENSE.md
+ */
 package com.mifos.feature.splash.navigation
 
 import androidx.navigation.NavGraphBuilder
@@ -7,29 +16,29 @@ import com.mifos.feature.splash.splash.SplashScreen
 
 fun NavGraphBuilder.splashNavGraph(
     navigatePasscode: () -> Unit,
-    navigateLogin: () -> Unit
+    navigateLogin: () -> Unit,
 ) {
     navigation(
         startDestination = SplashScreens.SplashScreen.route,
         route = SplashScreens.SplashScreenRoute.route,
     ) {
         splashScreenRoute(
             navigateLogin = navigateLogin,
-            navigatePasscode = navigatePasscode
+            navigatePasscode = navigatePasscode,
         )
     }
 }
 
 fun NavGraphBuilder.splashScreenRoute(
     navigatePasscode: () -> Unit,
-    navigateLogin: () -> Unit
+    navigateLogin: () -> Unit,
 ) {
     composable(
         route = SplashScreens.SplashScreen.route,
     ) {
         SplashScreen(
             navigatePasscode = navigatePasscode,
-            navigateLogin = navigateLogin
+            navigateLogin = navigateLogin,
         )
     }
-}
+}

feature/splash/src/main/java/com/mifos/feature/splash/navigation/SplashScreens.kt

@@ -1,9 +1,17 @@
+/*
+ * Copyright 2024 Mifos Initiative
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at https://mozilla.org/MPL/2.0/.
+ *
+ * See https://github.com/openMF/android-client/blob/master/LICENSE.md
+ */
 package com.mifos.feature.splash.navigation
 
 sealed class SplashScreens(val route: String) {
 
     data object SplashScreenRoute : SplashScreens("splash_screen_route")
 
     data object SplashScreen : SplashScreens("splash_screen")
-
-}
+}

feature/splash/src/main/java/com/mifos/feature/splash/splash/SplashScreen.kt

@@ -1,3 +1,12 @@
+/*
+ * Copyright 2024 Mifos Initiative
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at https://mozilla.org/MPL/2.0/.
+ *
+ * See https://github.com/openMF/android-client/blob/master/LICENSE.md
+ */
 package com.mifos.feature.splash.splash
 
 import androidx.compose.foundation.Image
@@ -20,47 +29,48 @@ import com.mifos.core.designsystem.theme.SummerSky
 import com.mifos.feature.splash.R
 
 @Composable
-fun SplashScreen(
-    viewmodel: SplashScreenViewmodel = hiltViewModel(),
+internal fun SplashScreen(
     navigatePasscode: () -> Unit,
-    navigateLogin: () -> Unit
+    viewmodel: SplashScreenViewmodel = hiltViewModel(),
+    navigateLogin: () -> Unit,
 ) {
     val state by viewmodel.isAuthenticated.collectAsStateWithLifecycle()
 
     SplashScreen(
         state = state,
         navigatePasscode = navigatePasscode,
-        navigateLogin = navigateLogin
+        navigateLogin = navigateLogin,
     )
 }
 
 @Composable
-fun SplashScreen(
+internal fun SplashScreen(
     state: Boolean?,
     navigatePasscode: () -> Unit,
-    navigateLogin: () -> Unit
+    navigateLogin: () -> Unit,
+    modifier: Modifier = Modifier,
 ) {
-
     when (state) {
         false -> navigateLogin()
         true -> navigatePasscode()
         else -> {}
     }
 
     MifosScaffold(
-        containerColor = SummerSky
+        modifier = modifier,
+        containerColor = SummerSky,
     ) { paddingValues ->
         Column(
             modifier = Modifier
                 .padding(paddingValues)
                 .fillMaxSize(),
             verticalArrangement = Arrangement.Center,
-            horizontalAlignment = Alignment.CenterHorizontally
+            horizontalAlignment = Alignment.CenterHorizontally,
         ) {
             Image(
                 modifier = Modifier.size(100.dp),
                 painter = painterResource(id = R.drawable.feature_splash_icon),
-                contentDescription = null
+                contentDescription = null,
             )
         }
     }
@@ -72,6 +82,6 @@ private fun SplashScreenPreview() {
     SplashScreen(
         state = false,
         navigatePasscode = {},
-        navigateLogin = {}
+        navigateLogin = {},
     )
-}
+}

feature/splash/src/main/java/com/mifos/feature/splash/splash/SplashScreenViewmodel.kt

@@ -1,6 +1,14 @@
+/*
+ * Copyright 2024 Mifos Initiative
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at https://mozilla.org/MPL/2.0/.
+ *
+ * See https://github.com/openMF/android-client/blob/master/LICENSE.md
+ */
 package com.mifos.feature.splash.splash
 
-import android.util.Log
 import androidx.lifecycle.ViewModel
 import androidx.lifecycle.viewModelScope
 import com.mifos.core.datastore.PrefManager
@@ -14,7 +22,7 @@ import javax.inject.Inject
 
 @HiltViewModel
 class SplashScreenViewmodel @Inject constructor(
-    private val prefManager: PrefManager
+    private val prefManager: PrefManager,
 ) : ViewModel() {
 
     private val _isAuthenticated = MutableStateFlow<Boolean?>(null)
@@ -28,5 +36,4 @@ class SplashScreenViewmodel @Inject constructor(
         delay(2000)
         _isAuthenticated.value = prefManager.isAuthenticated()
     }
-
-}
+}

feature/splash/src/test/java/com/mifos/feature/splash/ExampleUnitTest.kt

@@ -1,9 +1,17 @@
+/*
+ * Copyright 2024 Mifos Initiative
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at https://mozilla.org/MPL/2.0/.
+ *
+ * See https://github.com/openMF/android-client/blob/master/LICENSE.md
+ */
 package com.mifos.feature.splash
 
+import junit.framework.TestCase.assertEquals
 import org.junit.Test
 
-import org.junit.Assert.*
-
 /**
  * Example local unit test, which will execute on the development machine (host).
  *
@@ -14,4 +22,4 @@ class ExampleUnitTest {
     fun addition_isCorrect() {
         assertEquals(4, 2 + 2)
     }
-}
+}

mifosng-android/src/main/res/navigation/home_nav_graph.xml

@@ -39,15 +39,6 @@
     </activity>
 
     <!--    CenterActivity-->
-    <activity
-        android:id="@+id/centersActivity"
-        android:name="com.mifos.mifosxdroid.online.CentersActivity"
-        android:label="activity_centers"
-        tools:layout="@layout/activity_centers">
-        <argument
-            android:name="centerId"
-            app:argType="integer" />
-    </activity>
 
     <!--    GroupsActivity-->