Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hint in answer breaking markdown content #62

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

christophblessing
Copy link
Collaborator

@christophblessing christophblessing commented Apr 15, 2024

Description

This PR fixes the hint if the user answered a question correctly in answer breaking markdown content.

If you put a block of code in the markdown content, it will be strangely formatted after answering a question because we append - text to it.

Before

Screenshot 2024-04-15 at 17 15 13

After

Screenshot 2024-04-15 at 17 14 27

Decisions / Choices I made

I decided to fix it by adding a separate paragraph instead of appending the text to the content.
This way we don't change the content of the Markdown component.

Additionally, I think it made sense to also change the wording in the locales and right align it.
Input on the styling is appreciated.

Closes #46

Checklist

  • All checks pass successfully
  • All related commits are squashed together
  • The code follows the project's coding standards
  • The changes are properly documented / the relevant documentation is updated (if applicable)
  • Appropriate labels are added to this pull request

@christophblessing christophblessing force-pushed the cb/fix-markdown-formatting-in-label-hint branch from 2abcf8a to 104f09f Compare April 15, 2024 15:19
@christophblessing christophblessing self-assigned this Apr 15, 2024
@christophblessing christophblessing added the bug Something isn't working label Apr 15, 2024
@christophblessing christophblessing marked this pull request as ready for review April 15, 2024 15:48
src/locales/de.ts Outdated Show resolved Hide resolved
by adding a separate paragraph instead of appending the text to the content.

Closes #46
@christophblessing christophblessing force-pushed the cb/fix-markdown-formatting-in-label-hint branch from 104f09f to 06a43a7 Compare April 16, 2024 14:03
@christophblessing christophblessing merged commit 0413ef6 into main Apr 16, 2024
4 checks passed
@christophblessing christophblessing deleted the cb/fix-markdown-formatting-in-label-hint branch April 16, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Appending "correct" / "incorrect" to answers breaks markdown formatting
2 participants