Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XI-6316 Add referenceLink to question object #61

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

Janis4411
Copy link
Collaborator

@Janis4411 Janis4411 commented Apr 15, 2024

This MR introduces the reviewLink to the question object. Furthermore the results table has been expanded by the Review Link column to hold the reviewLink for each question, if there is one.
Also added tests for the Result component.

Screenshot with no question having a reviewLink:

Screenshot 2024-04-16 at 11 29 43

Screenshot with at least one question having a reviewLink:

Screenshot 2024-04-17 at 09 47 17

Checklist

Make sure all these items are checked before submitting the pull request

  • All checks pass successfully
  • All related commits are squashed together
  • The code follows the project's coding standards
  • The changes are properly documented / the relevant documentation is updated (if applicable)
  • Appropriate labels are added to this pull request

@Janis4411
Copy link
Collaborator Author

I'll take care of the pipeline errors! 🙂

@Janis4411 Janis4411 force-pushed the jv/XI-6316-Add-Review-link-to-questions branch 2 times, most recently from d9e06ab to 256cd2e Compare April 16, 2024 08:16
Copy link
Collaborator

@christophblessing christophblessing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening the PR, nice work!

I added my feedback. Can you please also add a screenshot to the description that show the result of your changes?

src/App.test.tsx Outdated Show resolved Hide resolved
src/locales/en.ts Outdated Show resolved Hide resolved
src/static/data.ts Outdated Show resolved Hide resolved
src/static/data.ts Outdated Show resolved Hide resolved
src/components/Result.test.tsx Outdated Show resolved Hide resolved
src/components/Result.tsx Outdated Show resolved Hide resolved
src/components/Result.tsx Outdated Show resolved Hide resolved
src/components/Result.tsx Outdated Show resolved Hide resolved
@Janis4411 Janis4411 force-pushed the jv/XI-6316-Add-Review-link-to-questions branch from 256cd2e to aeed36f Compare April 16, 2024 10:05
@christophblessing christophblessing added the enhancement New feature or request label Apr 16, 2024
@Janis4411 Janis4411 force-pushed the jv/XI-6316-Add-Review-link-to-questions branch from aeed36f to 0f789b7 Compare April 16, 2024 11:46
@Janis4411 Janis4411 force-pushed the jv/XI-6316-Add-Review-link-to-questions branch from 0f789b7 to 03be42f Compare April 16, 2024 14:15
@Janis4411 Janis4411 force-pushed the jv/XI-6316-Add-Review-link-to-questions branch 2 times, most recently from 89a473e to 228403e Compare April 17, 2024 07:53
Results table has been expanded by the Review Link column to hold
the reviewLink for each question, if there is one.
Also added tests for the Result component.
@Janis4411 Janis4411 force-pushed the jv/XI-6316-Add-Review-link-to-questions branch from 228403e to dad9232 Compare April 17, 2024 08:55
@christophblessing christophblessing merged commit fc0caea into main Apr 17, 2024
4 checks passed
@christophblessing christophblessing deleted the jv/XI-6316-Add-Review-link-to-questions branch April 17, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants