-
Notifications
You must be signed in to change notification settings - Fork 29
test: Add system tests for exercise administration #3008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e2d0d2a
to
1deabb1
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3008 +/- ##
==========================================
+ Coverage 70.05% 70.35% +0.30%
==========================================
Files 215 215
Lines 6846 7128 +282
==========================================
+ Hits 4796 5015 +219
- Misses 2050 2113 +63 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The exercise administration form is a critical pass. The test will secure the functionality with the upcoming changes. Relates to #2922
1deabb1
to
5b124c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
look good to me in general, I added a few nit-picky comments and suggestions
Co-authored-by: kkoehn <[email protected]>
Make it clear this test helper target choosen JS.
@kkoehn Can I ask you to have another look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This reverts commit 152b140.
The exercise administration form is a critical pass. The test will secure the functionality with the upcoming changes.
Relates to #2922