Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove any unpermitted parameters and raise if it reoccurs #1607

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

MrSerth
Copy link
Member

@MrSerth MrSerth commented Aug 25, 2024

So far, we had a few tests (and production-used code) that would log unpermitted parameters. This PR therefore addresses this issue by ensuring we are not sending unpermitted parameters during regular use. Furthermore, it raises if any unpermitted parameter is detected in development or test to make everyone aware.

This PR depends on the following two PRs to be merged first:

Only when those two PRs are merged, the tests in this branch will pass. Nevertheless, reviewing is already possible, @Dome-GER 😉

@MrSerth MrSerth added enhancement ruby Pull requests that update Ruby code labels Aug 25, 2024
@MrSerth MrSerth requested a review from Dome-GER August 25, 2024 11:37
@MrSerth MrSerth self-assigned this Aug 25, 2024
Copy link

codecov bot commented Aug 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.82%. Comparing base (eb92374) to head (0fe2eef).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1607      +/-   ##
==========================================
+ Coverage   94.79%   94.82%   +0.03%     
==========================================
  Files         133      133              
  Lines        3342     3344       +2     
==========================================
+ Hits         3168     3171       +3     
+ Misses        174      173       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MrSerth MrSerth force-pushed the raise_on_unpermitted_parameters branch from 2d3aceb to a529c5d Compare September 10, 2024 10:34
@Dome-GER Dome-GER marked this pull request as ready for review October 15, 2024 18:37
@MrSerth MrSerth force-pushed the raise_on_unpermitted_parameters branch 3 times, most recently from 9df78f3 to 402323c Compare October 15, 2024 19:03
This setting should ensure we don't re-introduce any code that silently "accepts" unpermitted parameters.
@MrSerth MrSerth force-pushed the raise_on_unpermitted_parameters branch from 402323c to 0fe2eef Compare October 15, 2024 19:07
@Dome-GER Dome-GER merged commit 6ba77de into master Oct 15, 2024
10 checks passed
@Dome-GER Dome-GER deleted the raise_on_unpermitted_parameters branch October 15, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants