ci: migrate release-please to reusable workflow#25
Merged
Conversation
Calls opencoreemr/github-workflows-public/.github/workflows/release-please-reusable.yml@0.0.1 instead of pasting the release-please-action invocation inline. Sets "annotated-tag": true in release-please-config.json so the openCoreEMR/release-please-action fork creates the tag as annotated directly via the GitHub git-tag API. This replaces the post-release "Convert to annotated tag" workaround step (and its long comment block). Smoke test for the wider Task 2 migration of all 12 caller repos. Assisted-by: Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the inline release-please workflow with a thin caller of the new reusable workflow at
opencoreemr/github-workflows-public/.github/workflows/release-please-reusable.yml@0.0.1.Sets
\"annotated-tag\": trueinrelease-please-config.jsonso the openCoreEMR/release-please-action fork creates the tag as annotated directly via the GitHub git-tag API. This replaces the post-release "Convert to annotated tag" workaround step and its long explanatory comment block.Net diff: -58 / +7. The workflow file goes from 69 lines to 16.
Smoke test for wider migration
This is the first of 12 caller-repo migrations under the release-please normalization plan. Picked first because its config is already manifest-mode and there are no downstream jobs gated on
release_created. If this works end-to-end, the same diff pattern applies to the other 11.Test plan
actionlintcleangit cat-file -t <tag>returnstag, notcommit).releases_createdoutput is\"true\"in the run logs.If the next release tag comes back as
commitinstead oftag, theannotated-tag: truesetting didn't propagate — escalate, don't paper over.