Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send volume changes to controller #310

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

wvengen
Copy link
Contributor

@wvengen wvengen commented Jun 12, 2020

Ad this moment, the volume sliders can not send midi changes. This is relevant for controllers with motorized faders and led-based (rotary or fader) controls.

Some controllers can also gradually change the volume, which doesn't work when volume changes sent by the controller are sent back to it. That's why this needs to be controlled as well.

This PR adds midi messages for all volume/pan/send midi events, and the ability to toggle echo for these messages. Tested on the Launchpad X (#309).

  • Code-style consistency, use Event::SOURCE or SOURCE (and the enum constants).

@wvengen wvengen mentioned this pull request Jun 17, 2020
@harryhaaren
Copy link
Member

@wvengen, any opens around this? Anything I can do in 30 mins to move it along? (And my apologies that I haven't been working on this stuff at all in recent months - but that's real life for me atm : )

@wvengen
Copy link
Contributor Author

wvengen commented Jun 14, 2021

Hi @harryhaaren thank you for your response! I'd love to get the PRs merged (even if it will take a while, also from my side).
If you could take a first look at the code and indicate the most important things to address, that would help. And also hear if you'd prefer the use of Event::SOURCE or SOURCE.

@Spengreb
Copy link
Contributor

A quick test of this seems to work well. Will try a few different midi controllers and report back.

@Spengreb
Copy link
Contributor

Spengreb commented Jul 11, 2024

Everything besides the pan dial is working exactly as intended on the the two midi controllers i have (FCB1010 and Alesis V25).

Not 100% sure but perhaps pan isnt working because it isnt track specific? At least thats how it looks in the binds

image

src/eventhandlerdsp.cxx Outdated Show resolved Hide resolved
@harryhaaren
Copy link
Member

Cool cool - thanks folks. Anything todo here, or ready for merge?

@wvengen
Copy link
Contributor Author

wvengen commented Aug 4, 2024

There's one codestyle question about whether to use SOURCE or Event::SOURCE. I think it's not important enough to block merging, but if a consistent codestyle is very important to you, you may want to provide guidance here. If you have limited time to spend, then I'd say: please go ahead and merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants