-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send volume changes to controller #310
base: master
Are you sure you want to change the base?
Conversation
8b50a61
to
e146bfe
Compare
@wvengen, any opens around this? Anything I can do in 30 mins to move it along? (And my apologies that I haven't been working on this stuff at all in recent months - but that's real life for me atm : ) |
Hi @harryhaaren thank you for your response! I'd love to get the PRs merged (even if it will take a while, also from my side). |
A quick test of this seems to work well. Will try a few different midi controllers and report back. |
Cool cool - thanks folks. Anything todo here, or ready for merge? |
There's one codestyle question about whether to use |
Ad this moment, the volume sliders can not send midi changes. This is relevant for controllers with motorized faders and led-based (rotary or fader) controls.
Some controllers can also gradually change the volume, which doesn't work when volume changes sent by the controller are sent back to it. That's why this needs to be controlled as well.
This PR adds midi messages for all volume/pan/send midi events, and the ability to toggle echo for these messages. Tested on the Launchpad X (#309).
Event::SOURCE
orSOURCE
(and the enum constants).