nuttx/arch: remove the custom board check in up_testset implementation #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
xiaoxiang781216
approved these changes
Dec 24, 2024
the up_testset implementation is common code, should not add custom board check Signed-off-by: guoshichao <[email protected]>
the include/nuttx/spinlock.h#up_testset() function is also controlled by ARCH_HAVE_TESTSET, so when ARCH_HAVE_CUSTOM_TESTSET is selected by boards, the include/nuttx/spinlock.h#up_testset() should also not be build, and using the board specific implementation. So in this case, if Option ARCH_HAVE_CUSTOM_TESTSET is enabled, it is assumed that Option ARCH_HAVE_TESTSET is also enabled. However, when Option ARCH_HAVE_TESTSET is enabled, it doesn't necessarily mean that Option ARCH_HAVE_CUSTOM_TESTSET is also enabled. In this way, it can be ensured that the implementation under the include/nuttx/spinlock.h#up_testset can also be controlled by Option ARCH_HAVE_CUSTOM_TESTSET. Signed-off-by: guoshichao <[email protected]>
extinguish
force-pushed
the
up_testset_fix
branch
from
9d9110d to
0049c2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the up_testset implementation is common code, should not add custom board check