SPP: Add dynamic log control for SPP data transmission#415
Open
Yezmax wants to merge 1 commit intoopen-vela:devfrom
Open
SPP: Add dynamic log control for SPP data transmission#415Yezmax wants to merge 1 commit intoopen-vela:devfrom
Yezmax wants to merge 1 commit intoopen-vela:devfrom
Conversation
Yezmax
requested review from
chengkai15,
gzh-terry,
huangyulong3,
hyson710,
zhangyuan376 and
zhongzhijie1
as code owners
gzh-terry
reviewed
Jan 29, 2026
gzh-terry
reviewed
Jan 29, 2026
gzh-terry
reviewed
Jan 29, 2026
gzh-terry
reviewed
Jan 29, 2026
gzh-terry
reviewed
Jan 29, 2026
gzh-terry
reviewed
Jan 29, 2026
Yezmax
force-pushed
the
feat/spp-dynamic-dump
branch
3 times, most recently
from
d7093cb to
a12afbe
Compare
chejinxian
reviewed
Feb 3, 2026
Contributor
Author
|
/check-cla |
✅ CLA Verification Complete@Yezmax All contributors have signed the CLA!
📋 View detailed check results: Action Run #21615949754 Your pull request can now proceed with the review process! 🎉 |
gzh-terry
reviewed
Feb 3, 2026
gzh-terry
reviewed
Feb 3, 2026
gzh-terry
reviewed
Feb 3, 2026
gzh-terry
previously approved these changes
Feb 3, 2026
Yezmax
force-pushed
the
feat/spp-dynamic-dump
branch
from
a12afbe to
bf13b2b
Compare
gzh-terry
reviewed
Feb 3, 2026
gzh-terry
previously approved these changes
Feb 3, 2026
gzh-terry
reviewed
Feb 5, 2026
Yezmax
force-pushed
the
feat/spp-dynamic-dump
branch
from
4a7fd08 to
8fbfaae
Compare
Yezmax
force-pushed
the
feat/spp-dynamic-dump
branch
2 times, most recently
from
d954c0d to
cad6bcc
Compare
gzh-terry
reviewed
Feb 5, 2026
gzh-terry
reviewed
Feb 5, 2026
| BT_LOGE("Spp write to slave port %d failed", device->conn_port); | ||
| break; | ||
| } | ||
| spp_dumpbuffer("master buffer write:", buf->buffer, buf->length); |
Contributor
There was a problem hiding this comment.
@chejinxian Please double check if these two "master write" are with the same meaning.
Yezmax
force-pushed
the
feat/spp-dynamic-dump
branch
from
cad6bcc to
81b811d
Compare
gzh-terry
reviewed
Feb 5, 2026
gzh-terry
reviewed
Feb 5, 2026
gzh-terry
previously approved these changes
Feb 5, 2026
Yezmax
force-pushed
the
feat/spp-dynamic-dump
branch
from
81b811d to
342d67f
Compare
gzh-terry
reviewed
Feb 5, 2026
gzh-terry
previously approved these changes
Feb 5, 2026
chengkai15
previously approved these changes
Feb 5, 2026
Yezmax
force-pushed
the
feat/spp-dynamic-dump
branch
from
342d67f to
0c8b7a8
Compare
chengkai15
reviewed
Feb 6, 2026
bug: v/85159 Implemented dynamically controlled SPP data dump functionality for troubleshooting SPP transmission errors. Modified spp_service.c, changing the spp_dumpbuffer macro to the spp_dump_buffer function, adding checks for bt_log_spp_dump_is_enable(), NULL pointer safety, and a maximum 16-byte limit. Added support for LOG_ID_SPP_DUMP and spp_dump_enable state management in log_server.c. Added handling for BT_DEBUG_MODE_SPP_DUMP in adapter_service.c, added support for the spp_dump command in bt_tools.c, and added the BT_DEBUG_MODE_SPP_DUMP enumeration in bluetooth.h. Signed-off-by: v-chenghuijin <v-chenghuijin@xiaomi.com>
Yezmax
force-pushed
the
feat/spp-dynamic-dump
branch
from
0c8b7a8 to
a6aa3cc
Compare
chengkai15
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bug: v/85159
Implemented dynamically controlled SPP data dump functionality for troubleshooting SPP transmission errors.
Modified spp_service.c, changing the spp_dumpbuffer macro to the
spp_dump_buffer function, adding checks for bt_log_spp_dump_is_enable(),
NULL pointer safety, and a maximum 16-byte limit. Added support for
LOG_ID_SPP_DUMP and spp_dump_enable state management in log_server.c.
Added handling for BT_DEBUG_MODE_SPP_DUMP in adapter_service.c, added
support for the spp_dump command in bt_tools.c, and added the
BT_DEBUG_MODE_SPP_DUMP enumeration in bluetooth.h.